devtools: Use getOffsetMetadata in Frame#42874
Merged
atbrakhi merged 1 commit intoservo:mainfrom Feb 26, 2026
Merged
Conversation
servo-highfive
added
the
S-awaiting-review
eerii
approved these changes
Feb 26, 2026
Member
eerii
left a comment
eerii
left a comment
There was a problem hiding this comment.
It's good to see the highlights in the proper place :)
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
servo-highfive
added
S-needs-rebase
atbrakhi
force-pushed
the
use_getoffsetmetadata
branch
from
08e20fb to
d4601c2
Compare
By using getOffsetMetadata now, it is showing the correct line and column for each frame when breakpoint is being set. Co-authored-by: eri <eri@igalia.com> Signed-off-by: atbrakhi <atbrakhi@igalia.com>
atbrakhi
force-pushed
the
use_getoffsetmetadata
branch
from
d4601c2 to
5055d31
Compare
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
shubhamg13
pushed a commit
to shubhamg13/servo
that referenced
this pull request
Mar 2, 2026
Use [`getOffsetMetadata`](https://firefox-source-docs.mozilla.org/js/Debugger/Debugger.Script.html#getoffsetmetadata-offset) in Frame By using getOffsetMetadata now, it is showing the correct line and column for each frame when breakpoint is being set. Testing: all existing tests are passing Fixes: Part of servo#36027 Signed-off-by: atbrakhi <atbrakhi@igalia.com> Co-authored-by: eri <eri@igalia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
getOffsetMetadatain FrameBy using getOffsetMetadata now, it is showing the correct line and column for each frame when breakpoint is being set.
Testing: all existing tests are passing
Fixes: Part of #36027