script: use &mut JSContext in MessagePort::PostMessage#42880
Merged
Gae24 merged 1 commit intoservo:mainfrom Feb 26, 2026
Merged
script: use &mut JSContext in MessagePort::PostMessage#42880Gae24 merged 1 commit intoservo:mainfrom
&mut JSContext in MessagePort::PostMessage#42880Gae24 merged 1 commit intoservo:mainfrom
Conversation
Signed-off-by: Onur Sahin <sahinonur2000@hotmail.com>
onsah
commented
Feb 26, 2026
| self.post_message_impl(cx, message, guard) | ||
| #[expect(unsafe_code)] | ||
| let guard = unsafe { CustomAutoRooterGuard::new(cx.raw_cx(), &mut rooted) }; | ||
| self.post_message_impl(cx.into(), message, guard) |
Contributor
Author
There was a problem hiding this comment.
I tried to push the change to MessagePort::post_message_impl, but that function is also used in MessagePort::pack_and_post_message, which seems to affect a lot of places. I am not sure if those changes are in scope.
Contributor
There was a problem hiding this comment.
Yeah MessagePort::pack_and_post_message is used in stream code too, which requires more code changes. If you want to look into it, you should start propagating JSContext from here:
servo-highfive
added
the
S-awaiting-review
Gae24
approved these changes
Feb 26, 2026
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
shubhamg13
pushed a commit
to shubhamg13/servo
that referenced
this pull request
Mar 2, 2026
Replace crate::script_runtime::JSContext with js::context::JSContext in `MessagePort::PostMessage` Testing: Builds and runs fine Fixes: part of servo#42347 Signed-off-by: Onur Sahin <sahinonur2000@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace crate::script_runtime::JSContext with js::context::JSContext in
MessagePort::PostMessageTesting: Builds and runs fine
Fixes: part of #42347