devtools: Avoid creating unnecessary new frame actors#42906
Merged
atbrakhi merged 1 commit intoservo:mainfrom Feb 27, 2026
Merged
devtools: Avoid creating unnecessary new frame actors#42906atbrakhi merged 1 commit intoservo:mainfrom
atbrakhi merged 1 commit intoservo:mainfrom
Conversation
Before we were creating a new frame actor each time we paused, even if the frame object in debugger.js was the same. Now we avoid this by reusing the same frame actor id. This helps our upcoming work on onStep, onPop, and onEnterFrame hooks. Signed-off-by: eri <eri@igalia.com> Co-authored-by: atbrakhi <atbrakhi@igalia.com>
servo-highfive
added
the
S-awaiting-review
atbrakhi
approved these changes
Feb 27, 2026
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before we were creating a new frame actor each time we paused, even if the frame object in debugger.js was the same. Now we avoid this by reusing the same frame actor id.
This helps our upcoming work on onStep, onPop, and onEnterFrame hooks.
Testing: Ran
mach test-devtoolsand manually check that it worksPart of: #36027