Unify servo package naming#42916
Conversation
This is a prepration for publishing to crates.io. - Add `servo-` prefixes to avoid name collisions on crates.io - Use `-` instead of `_` in package names. - Rename the crates to their original names in Cargo.toml, to keep the diff minimal - Rename `media` to `servo-media-thread` to avoid name collision with `servo-media` (originally from the media repository). Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
jschwe
requested review from
Loirooriol,
gterzian,
mrobinson,
nicoburns,
sagudev,
simonwuelker and
yezhizhen
as code owners
servo-highfive
added
the
S-awaiting-review
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
jschwe
force-pushed
the
servo_packages
branch
from
587bd4d to
31c5442
Compare
nicoburns
left a comment
nicoburns
left a comment
There was a problem hiding this comment.
Changes look good.
I think it might also make sense to rename *-traits crates to *-api for consistency, as I believe *-traits and *-api crates serve fundamentally the same purpose, but we have to two different naming conventions for them.
servo-highfive
removed
the
S-awaiting-review
|
We may also want to move all the repo-local (path) dependency specifications to being defined at the workspace level as that makes it much easier to update the version specifications for intra-repo dependency links (which are required for publishing to crates.io). Otherwise you have to dig through the (we have already applied this pattern to the stylo (https://github.com/servo/stylo/blob/main/Cargo.toml#L22) and html5ever (https://github.com/servo/html5ever/blob/main/Cargo.toml#L20) repos) (this could be done in a follow-up) |
Note this is inconsistent with Stylo |
The stylo crates are already published though, right? Is this just a note, or a blocking concern that should be discussed first? |
Also note the discussion about the naming here: #general > Switch remaining git dependencies to crates.io |
Added the link to the PR description, since that was the basis of this PR - thanks for the reminder. |
|
Not a blocking concern, it's just a bit unfortunate |
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This is a preparation for publishing to crates.io. Changes include: - Add `servo-` prefixes to avoid name collisions on crates.io - Use `-` instead of `_` in package names. - Rename the crates to their original names in Cargo.toml, to keep the diff minimal - Rename `media` to `servo-media-thread` to avoid name collision with `servo-media` (originally from the media repository). This is an outcome of the previous discussion at [#general > Switch remaining git dependencies to crates.io](https://servo.zulipchat.com/#narrow/channel/263398-general/topic/Switch.20remaining.20git.20dependencies.20to.20crates.2Eio/with/576336288) Testing: This should be mostly covered by our CI, but some amount of breakage is to be expected, since some package names could still be referenced from scripts which are not tested or run in CI. [mach try run](https://github.com/jschwe/servo/actions/runs/22502945949) --------- Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
5 participants
This is a preparation for publishing to crates.io. Changes include:
servo-prefixes to avoid name collisions on crates.io-instead of_in package names.to keep the diff minimal
mediatoservo-media-threadto avoid name collision withservo-media(originally from the media repository).This is an outcome of the previous discussion at #general > Switch remaining git dependencies to crates.io
Testing: This should be mostly covered by our CI, but some amount of breakage is to be expected, since some package names could still be referenced from scripts which are not tested or run in CI. mach try run