fonts: Fix font-weight matching behavior for "simple" font families

[shubhamg13]

This aligns with behavior with spec, by selecting BOLD for the weights greater than 500.

• W3C Specs: font-style-matching

If the desired weight is greater than 500, weights greater than or equal to the desired weight are checked in ascending order followed by weights below the desired weight in descending order until a match is found.

• Firefox: https://phabricator.services.mozilla.com/D274775

Testing: This causes a WPT test to start passing.

[github-actions]

🔨 Triggering try run (#22890499462) for Linux (WPT)

[github-actions]

Test results for linux-wpt from try job (#22890499462):

Flaky unexpected result (26)

• TIMEOUT /FileAPI/url/url-in-tags-revoke.window.html (#19978)
  • TIMEOUT [expected PASS] subtest: Fetching a blob URL immediately before revoking it works in <script> tags.

    Test timed out
    

• FAIL [expected PASS] /css/css-backgrounds/background-size-041.html
• OK /css/css-fonts/generic-family-keywords-002.html (#40929)
  • FAIL [expected PASS] subtest: font-family: -webkit-serif treated as <font-family>, not <generic-name>

    assert_equals: expected 30 but got 50
    

  • FAIL [expected PASS] subtest: font-family: -webkit-sans-serif treated as <font-family>, not <generic-name>

    assert_equals: expected 30 but got 50
    

  • FAIL [expected PASS] subtest: font-family: -webkit-cursive treated as <font-family>, not <generic-name>

    assert_equals: expected 30 but got 50
    

  • FAIL [expected PASS] subtest: font-family: -webkit-fantasy treated as <font-family>, not <generic-name>

    assert_equals: expected 30 but got 50
    

  • FAIL [expected PASS] subtest: font-family: -webkit-monospace treated as <font-family>, not <generic-name>

    assert_equals: expected 30 but got 50
    

  • FAIL [expected PASS] subtest: font-family: -webkit-system-ui treated as <font-family>, not <generic-name>

    assert_equals: expected 30 but got 50
    

  • FAIL [expected PASS] subtest: font-family: -webkit-math treated as <font-family>, not <generic-name>

    assert_equals: expected 30 but got 50
    

  • PASS [expected FAIL] subtest: font-family: -webkit-generic(fangsong) treated as <font-family>, not <generic-name>
  • PASS [expected FAIL] subtest: font-family: -webkit-generic(kai) treated as <font-family>, not <generic-name>
  • PASS [expected FAIL] subtest: font-family: -webkit-generic(khmer-mul) treated as <font-family>, not <generic-name>
  • And 12 more unexpected results...
• FAIL [expected PASS] /css/css-ui/webkit-appearance-meter-001.html
• OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
  • PASS [expected FAIL] subtest: sec-fetch-mode
• OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
  • PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-site destination
• ERROR [expected OK] /fetch/metadata/window-open.https.sub.html (#40339)
• OK /html/browsers/browsing-the-web/navigating-across-documents/008.html (#24456)
  • PASS [expected FAIL] subtest: Link with onclick form submit to javascript url and href navigation
• OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
  • PASS [expected FAIL] subtest: Cross-origin navigation started from unload handler must be ignored
• OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
  • PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored
• OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
  • FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted

    assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])
    

• OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
  • FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted

    assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])
    

• TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/document-with-fragment-nonexistent.html (#28259)
  • TIMEOUT [expected FAIL] subtest: Autofocus elements in top-level browsing context's documents with non-existent fragments should work.

    Test timed out
    

• TIMEOUT /html/semantics/embedded-content/media-elements/autoplay-allowed-by-feature-policy.https.sub.html (#41404)
  • PASS [expected TIMEOUT] subtest: Feature-Policy header: autoplay * allows same-origin iframes.
• TIMEOUT /html/semantics/embedded-content/media-elements/autoplay-default-feature-policy.https.sub.html (#41193)
  • PASS [expected TIMEOUT] subtest: Default "autoplay" feature policy ["self"] allows same-origin iframes.
• TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigate_other_frame_popup.sub.html (#39702)
  • TIMEOUT [expected FAIL] subtest: Sandboxed iframe can not navigate other frame's popup

    Test timed out
    

• OK /html/semantics/forms/form-submission-0/form-submit-iframe-then-location-navigate.html (#29634)
  • PASS [expected FAIL] subtest: Verifies that location navigations take precedence when following form submissions.
• OK /html/semantics/forms/form-submission-0/jsurl-form-submit.tentative.html (#36489)
  • PASS [expected FAIL] subtest: Verifies that form submissions scheduled inside javascript: urls take precedence over the javascript: url's return value.
• TIMEOUT [expected OK] /html/user-activation/navigation-state-reset-sameorigin.html
  • TIMEOUT [expected PASS] subtest: Post-navigation state reset.

    Test timed out
    

• OK /preload/prefetch-document.html (#37210)
  • FAIL [expected PASS] subtest: different-site document prefetch with 'as=document' should not be consumed

    assert_equals: expected 2 but got 1
    

• OK [expected CRASH] /resource-timing/render-blocking-status-link.html (#41664)
• TIMEOUT /trusted-types/trusted-types-navigation.html?06-10 (#37920)
  • TIMEOUT [expected FAIL] subtest: Navigate a frame via anchor with javascript:-urls in report-only mode.

    Test timed out
    

  • NOTRUN [expected TIMEOUT] subtest: Navigate a frame via anchor with javascript:-urls w/ default policy in report-only mode.
• OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?31-35 (#38034)
  • PASS [expected TIMEOUT] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in report-only mode.
  • FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy throwing an exception in enforcing mode.

    promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
    

  • FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy throwing an exception in report-only mode.

    promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
    

  • FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy making the URL invalid in enforcing mode.

    promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
    

• CRASH [expected OK] /webaudio/the-audio-api/the-mediastreamaudiodestinationnode-interface/closed-audiocontext-construction.html
• OK [expected TIMEOUT] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html (#29053)
  • PASS [expected TIMEOUT] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
• ERROR [expected OK] /workers/baseurl/alpha/sharedworker-in-worker.html (#21315)

Stable unexpected results that are known to be intermittent (17)

• OK /_mozilla/css/offset_properties_inline.html (#40543)
  • FAIL [expected PASS] subtest: offsetTop

    assert_equals: offsetTop of #inline-1 should be 0. expected 0 but got -1
    

  • FAIL [expected PASS] subtest: offsetLeft

    assert_equals: offsetLeft of #inline-2 should be 40. expected 40 but got 25
    

• FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
• TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
  • TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo

    Test timed out
    

• CRASH [expected PASS] /_mozilla/shadow-dom/move-element-with-ua-shadow-tree-crash.html (#39473)
• OK /_webgl/conformance/textures/misc/texture-upload-size.html (#21770)
  • PASS [expected FAIL] subtest: WebGL test #45
  • PASS [expected FAIL] subtest: WebGL test #47
  • PASS [expected FAIL] subtest: WebGL test #49
  • PASS [expected FAIL] subtest: WebGL test #51
  • FAIL [expected PASS] subtest: WebGL test #53

    assert_true: Texture was smaller than the expected size 2x2 expected true got false
    

  • FAIL [expected PASS] subtest: WebGL test #55

    assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false
    

  • FAIL [expected PASS] subtest: WebGL test #57

    assert_true: Texture was smaller than the expected size 2x2 expected true got false
    

  • FAIL [expected PASS] subtest: WebGL test #59

    assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false
    

  • PASS [expected FAIL] subtest: WebGL test #61
  • PASS [expected FAIL] subtest: WebGL test #63
  • And 10 more unexpected results...
• OK /content-security-policy/frame-ancestors/frame-ancestors-path-ignored.window.html (#36468)
  • FAIL [expected PASS] subtest: A 'frame-ancestors' CSP directive with a URL that includes a path should be ignored.

    assert_unreached: The IFrame should have been blocked (or cross-origin). It wasn't. Reached unreachable code
    

• OK /css/css-fonts/generic-family-keywords-001.html (#37467)
  • FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted generic(nastaliq)

    assert_equals: quoted generic(nastaliq) matches  @font-face rule expected 50 but got 30
    

• OK /css/css-fonts/generic-family-keywords-003.html (#38994)
  • PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted cursive (drawing text in a canvas)
  • PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted fantasy (drawing text in a canvas)
  • PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted monospace (drawing text in a canvas)
  • PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted system-ui (drawing text in a canvas)
  • PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted math (drawing text in a canvas)
  • PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(fangsong) (drawing text in a canvas)
  • PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(kai) (drawing text in a canvas)
  • PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(khmer-mul) (drawing text in a canvas)
• OK [expected ERROR] /focus/focus-event-after-switching-iframes.sub.html (#40368)
• OK [expected TIMEOUT] /html/anonymous-iframe/indexeddb.tentative.https.window.html (#39254)
  • FAIL [expected TIMEOUT] subtest: indexeddb

    assert_equals: expected (undefined) undefined but got (string) "8453b0df-6eb1-41cf-9a9d-7586d3d2fa1c"
    

• OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment.html (#20768)
  • FAIL [expected PASS] subtest: Tests that a fragment navigation in the unload handler will not block the initial navigation

    assert_equals: expected "" but got "#fragment"
    

• OK /html/browsers/history/the-history-interface/traverse_the_history_2.html (#21383)
  • FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted

    assert_array_equals: Pages opened during history navigation expected property 1 to be 3 but got 2 (expected array [6, 3] got [6, 2])
    

• TIMEOUT /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
  • FAIL [expected TIMEOUT] subtest: Host element with delegatesFocus should support autofocus

    assert_equals: expected Element node <div autofocus=""></div> but got Element node <body><div autofocus=""></div></body>
    

  • TIMEOUT [expected NOTRUN] subtest: Host element with delegatesFocus including no focusable descendants should be skipped

    Test timed out
    

• OK /resource-timing/test_resource_timing.html (#25720)
  • PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img)
  • FAIL [expected PASS] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (link)

    assert_equals: expected 8.099999999999998 but got 8.1
    

  • PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (xmlhttprequest)
• OK /touch-events/single-tap-when-touchend-listener-use-sync-xhr.html (#41175)
  • PASS [expected FAIL] subtest: Click event should be fired when touchend opens synchronous XHR
• OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?26-30 (#38807)
  • PASS [expected TIMEOUT] subtest: Navigate a window via form-submission with javascript:-urls in report-only mode.
  • PASS [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ default policy in report-only mode.
  • PASS [expected NOTRUN] subtest: Navigate a frame via form-submission with javascript:-urls in enforcing mode.
  • PASS [expected NOTRUN] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in enforcing mode.
• ERROR [expected OK] /webxr/render_state_update.https.html (#27535)

[github-actions]

✨ Try run (#22890499462) succeeded.