script: Pass &mut JSContext in trusted types interfaces#43183
Merged
TimvdLippe merged 1 commit intoservo:mainfrom Mar 13, 2026
Merged
script: Pass &mut JSContext in trusted types interfaces#43183TimvdLippe merged 1 commit intoservo:mainfrom
TimvdLippe merged 1 commit intoservo:mainfrom
Conversation
Part of servo#40600 Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
TimvdLippe
force-pushed
the
trusted-types-cx
branch
from
9d0ce86 to
6eed75a
Compare
servo-highfive
added
the
S-awaiting-review
Gae24
approved these changes
Mar 13, 2026
Contributor
Gae24
left a comment
Gae24
left a comment
There was a problem hiding this comment.
Unless there's another JSContext in scope, could you import it?
servo-highfive
removed
the
S-awaiting-review
Contributor
Author
|
I would say we should do that as a post-cleanup of the migration. That way it's a lot easier to clean it up, rather than when things are moving around. |
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #40600