Skip to content

devtools: Implement object and function property preview#43356

Merged
atbrakhi merged 2 commits intoservo:mainfrom
atbrakhi:preview_popup_v2
Mar 18, 2026
Merged

devtools: Implement object and function property preview#43356
atbrakhi merged 2 commits intoservo:mainfrom
atbrakhi:preview_popup_v2

Conversation

@atbrakhi
Copy link
Copy Markdown
Member

@atbrakhi atbrakhi commented Mar 17, 2026

Implement property preview for the debugger popup. When hovering over variables while paused at a breakpoint, users can now see object properties and function metadata

Testing: Current tests are passing. Manual testing.
Fixes: Part of #36027

image image image

@atbrakhi atbrakhi requested a review from gterzian as a code owner March 17, 2026 15:40
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 17, 2026
@atbrakhi atbrakhi requested a review from eerii March 17, 2026 15:41
@atbrakhi
Copy link
Copy Markdown
Member Author

@eerii I couldn’t make it any shorter. It is complicated. Everything is tightly coupled, and when I tried to split it into separate PRs, it only became more complex and confusing. There’s a lot going on here, but the good thing is it’s mostly limited to functions and objects, other parts are untouched.

I also had arguments support in this PR, but I removed it because it was making change bigger. It’s better to land this first, and then I’ll send another PR for showing arguments in the preview.

I’ve tried to keep the implementation close to Firefox, while also keeping in mind that we’ll be adding more features in the future. That does mean some extra code in debugger.js, for example parts of this could have been simpler or even in the same function. But since we’ll be building on this, I decided to lay a foundation for future work. We can now implement on top of this.

I’ve documented things as much as I could, but I’m also happy to walk you through the changes on a call. Let me know!

Implement property preview for the debugger popup. When hovering over
variables while paused at a breakpoint, users can now see object
properties and function metadata

Signed-off-by: atbrakhi <atbrakhi@igalia.com>
Copy link
Copy Markdown
Member

@eerii eerii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most comments are for followups, the rest looks great! :)

Comment thread components/devtools/actors/console.rs
Comment thread components/devtools/actors/object.rs Outdated
Comment thread components/script_bindings/webidls/DebuggerEvalEvent.webidl
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Mar 18, 2026
Co-authored-by: eri <eri@igalia.com>
Signed-off-by: atbrakhi <atbrakhi@igalia.com>
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 18, 2026
@atbrakhi atbrakhi enabled auto-merge March 18, 2026 09:15
@atbrakhi atbrakhi added this pull request to the merge queue Mar 18, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 18, 2026
Merged via the queue into servo:main with commit d3ca63c Mar 18, 2026
33 checks passed
@atbrakhi atbrakhi deleted the preview_popup_v2 branch March 18, 2026 10:03
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 18, 2026
Gae24 pushed a commit to Gae24/servo that referenced this pull request Mar 26, 2026
…3356)

Implement property preview for the debugger popup. When hovering over
variables while paused at a breakpoint, users can now see object
properties and function metadata

Testing: Current tests are passing. Manual testing.
Fixes: Part of servo#36027 

<img width="1507" height="876" alt="image"
src="https://github.com/user-attachments/assets/31c95010-dab9-4b2c-a9b1-da6a29aa0de1"
/>

<img width="360" height="365" alt="image"
src="https://github.com/user-attachments/assets/50d19979-c0b2-4278-b19b-85c0c0318ab4"
/>
<img width="370" height="365" alt="image"
src="https://github.com/user-attachments/assets/3b74ef26-055b-4e49-848e-e7758f8d1de6"
/>

---------

Signed-off-by: atbrakhi <atbrakhi@igalia.com>
Co-authored-by: eri <eri@igalia.com>
@eerii eerii mentioned this pull request Apr 16, 2026
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants