devtools: Implement object and function property preview#43356
devtools: Implement object and function property preview#43356atbrakhi merged 2 commits intoservo:mainfrom
object and function property preview#43356Conversation
|
@eerii I couldn’t make it any shorter. It is complicated. Everything is tightly coupled, and when I tried to split it into separate PRs, it only became more complex and confusing. There’s a lot going on here, but the good thing is it’s mostly limited to functions and objects, other parts are untouched. I also had I’ve tried to keep the implementation close to Firefox, while also keeping in mind that we’ll be adding more features in the future. That does mean some extra code in debugger.js, for example parts of this could have been simpler or even in the same function. But since we’ll be building on this, I decided to lay a foundation for future work. We can now implement on top of this. I’ve documented things as much as I could, but I’m also happy to walk you through the changes on a call. Let me know! |
Implement property preview for the debugger popup. When hovering over variables while paused at a breakpoint, users can now see object properties and function metadata Signed-off-by: atbrakhi <atbrakhi@igalia.com>
ed54e1e to
347cf42
Compare
eerii
left a comment
There was a problem hiding this comment.
Most comments are for followups, the rest looks great! :)
Co-authored-by: eri <eri@igalia.com> Signed-off-by: atbrakhi <atbrakhi@igalia.com>
…3356) Implement property preview for the debugger popup. When hovering over variables while paused at a breakpoint, users can now see object properties and function metadata Testing: Current tests are passing. Manual testing. Fixes: Part of servo#36027 <img width="1507" height="876" alt="image" src="https://github.com/user-attachments/assets/31c95010-dab9-4b2c-a9b1-da6a29aa0de1" /> <img width="360" height="365" alt="image" src="https://github.com/user-attachments/assets/50d19979-c0b2-4278-b19b-85c0c0318ab4" /> <img width="370" height="365" alt="image" src="https://github.com/user-attachments/assets/3b74ef26-055b-4e49-848e-e7758f8d1de6" /> --------- Signed-off-by: atbrakhi <atbrakhi@igalia.com> Co-authored-by: eri <eri@igalia.com>
Implement property preview for the debugger popup. When hovering over variables while paused at a breakpoint, users can now see object properties and function metadata
Testing: Current tests are passing. Manual testing.
Fixes: Part of #36027