layout: Do not consider for LCP if using fallback size#43378
Draft
shubhamg13 wants to merge 2 commits intoservo:mainfrom
Draft
layout: Do not consider for LCP if using fallback size#43378shubhamg13 wants to merge 2 commits intoservo:mainfrom
shubhamg13 wants to merge 2 commits intoservo:mainfrom
Conversation
Signed-off-by: Shubham Gupta <shubham.gupta@chromium.org>
servo-highfive
added
the
S-awaiting-review
Member
|
I think this just missing a test and perhaps a link to the specification if one is available. |
Member
Author
I need some more time on this, need little more research on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This saves from reporting LCP candidates with wrong dimensions and non worty candidates.
Testing: TODO