webdriver: Improve error reporting for Cookie Addition#43690
Merged
TimvdLippe merged 4 commits intoservo:mainfrom Mar 26, 2026
Merged
webdriver: Improve error reporting for Cookie Addition#43690TimvdLippe merged 4 commits intoservo:mainfrom
TimvdLippe merged 4 commits intoservo:mainfrom
Conversation
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
servo-highfive
added
the
S-awaiting-review
Collaborator
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#58773) with upstreamable changes. |
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
yezhizhen
force-pushed
the
improve-cookie
branch
from
4bc9340 to
84c6d2a
Compare
yezhizhen
commented
Mar 26, 2026
Member
Author
yezhizhen
left a comment
yezhizhen
left a comment
There was a problem hiding this comment.
Bug with spec again. All browsers behave like what we implements in this PR.
Comment on lines
+1488
to
+1490
| // If cookie domain is not equal to session's current browsing context's | ||
| // active document's domain, return error with error code invalid cookie domain. | ||
| (false, Some(_)) => Err(ErrorStatus::InvalidCookieDomain), |
Member
Author
There was a problem hiding this comment.
Actually the spec says "invalid argument" for this. However, all browsers do InvalidCookieDomain.
The definition of InvalidCookieDomain is: An illegal attempt was made to set a cookie under a different domain than the current page. This makes sense, and we should fix spec to throw "invalid cookie domain" instead of "argument".
Another proof is, the new test I added but reverted fails for all other browsers:
def test_add_cookie_with_domain_not_matching_current_domain(session, url):
session.url = url("/common/blank.html")
new_cookie = {
"name": "hello",
"value": "world",
"domain": "example.com",
"path": "/",
"httpOnly": False,
"secure": False
}
response = add_cookie(session, new_cookie)
assert_error(response, "invalid argument")
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#58773). |
yezhizhen
added
T-webdriver
Collaborator
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#58773) title and body. |
|
🔨 Triggering try run (#23596269609) for Linux (WPT) |
Collaborator
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#58773) title and body. |
Collaborator
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#58773) title and body. |
|
Test results for linux-wpt from try job (#23596269609): Flaky unexpected result (24)
Stable unexpected results that are known to be intermittent (23)
|
|
✨ Try run (#23596269609) succeeded. |
TimvdLippe
approved these changes
Mar 26, 2026
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the error reporting for cookie addition.
Most notably, when
There is a bug with spec: #43690 (comment).
We fix spec in w3c/webdriver#1955 and
make sure Servo behaves consistently with other browsers.
Testing: Added one test for invalid expiry time. New passing with existing.