canvas: Don't include text run without string or font when build_unshaped_text_runs#43717
Merged
yezhizhen merged 3 commits intoservo:mainfrom Mar 27, 2026
Merged
canvas: Don't include text run without string or font when build_unshaped_text_runs#43717yezhizhen merged 3 commits intoservo:mainfrom
build_unshaped_text_runs#43717yezhizhen merged 3 commits intoservo:mainfrom
Conversation
servo-highfive
added
the
S-awaiting-review
yezhizhen
changed the title
build_unshaped_text_runs
mrobinson
approved these changes
Mar 27, 2026
servo-highfive
removed
the
S-awaiting-review
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
servo-highfive
added
the
S-awaiting-review
Member
Author
|
Gonna add a crash test for this. |
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
servo-highfive
added
the
S-awaiting-merge
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 27, 2026
…haped_text_runs` (#43717) As titled. The `Vec<UnshapedTextRun>` produced by `fn build_unshaped_text_runs` is only used by `into_shaped_text_run`, which filters out those without string or font. It is better to not allocate them in the first place. Testing: [Try](https://github.com/servo/servo/actions/runs/23642089615). Added a Servo-specific crash test to ensure we will not have empty font/string in a text run. --------- Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As titled. The
Vec<UnshapedTextRun>produced byfn build_unshaped_text_runsis only used by
into_shaped_text_run, which filters out those without string or font.It is better to not allocate them in the first place.
Testing: Try.
Added a Servo-specific crash test to ensure we will not have empty font/string in a text run.