devtools: Replace new with register for PerformanceActor#43921
Merged
Conversation
Signed-off-by: Sabb <sarafaabbas@gmail.com>
servo-highfive
added
the
S-awaiting-review
eerii
approved these changes
Apr 4, 2026
servo-highfive
removed
the
S-awaiting-review
eerii
requested changes
Apr 4, 2026
| // Global actors | ||
| let device_name = DeviceActor::register(registry); | ||
| let perf = PerformanceActor::new(registry.new_name::<PerformanceActor>()); | ||
| let perf_actor = PerformanceActor::register(registry); |
Member
There was a problem hiding this comment.
Sorry. Could you change this to performance_name? We have to keep the perf_actor in the struct below, but we can change this one.
Contributor
Author
There was a problem hiding this comment.
Okay, I'm still on the branch :)
servo-highfive
added
S-needs-code-changes
Signed-off-by: Sabb <sarafaabbas@gmail.com>
sabbCodes
force-pushed
the
issue-43800-performance-actor
branch
from
feca6bf to
3d3bfeb
Compare
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced new with register for PerformanceActor in performance.rs & root.rs
Testing: No testing required, compiles successfully.
Fixes: Part of #43800