net: Replace custom HttpStatus type with a wrapper around http::StatusCode#44230
Draft
Narfinger wants to merge 4 commits intoservo:mainfrom
Draft
net: Replace custom HttpStatus type with a wrapper around http::StatusCode#44230Narfinger wants to merge 4 commits intoservo:mainfrom
Narfinger wants to merge 4 commits intoservo:mainfrom
Conversation
|
🔨 Triggering try run (#24447026253) for Linux (WPT) |
❌ 8 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
|
Test results for linux-wpt from try job (#24447026253): Flaky unexpected result (29)
Stable unexpected results that are known to be intermittent (22)
Stable unexpected results (76)
|
|
|
|
🔨 Triggering try run (#24448646526) for Linux (WPT) |
|
Test results for linux-wpt from try job (#24448646526): Flaky unexpected result (29)
Stable unexpected results that are known to be intermittent (18)
Stable unexpected results (74)
|
|
|
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
be5f859 to
6254f7f
Compare
|
🔨 Triggering try run (#24498966382) for Linux (WPT) |
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
|
Test results for linux-wpt from try job (#24498966382): Flaky unexpected result (29)
Stable unexpected results that are known to be intermittent (22)
Stable unexpected results (16)
|
|
|
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
|
🔨 Triggering try run (#24516819514) for Linux (WPT) |
|
Test results for linux-wpt from try job (#24516819514): Flaky unexpected result (44)
Stable unexpected results that are known to be intermittent (13)
Stable unexpected results (9)
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, servo implemented a custom HttpStatus type which contained the code (u16) and a message (Vec). The rust ecosystem standardizes around StatusCode from the http crate which is just a NonZeroU16, making it more efficient.
Additionally, the previous HttpStatus encoded an uninitialized value with a separate method new_error and (setting u16=0) and is_error. These can be confusing as HttpStatus::is_error is different than !StatusCode::is_success.
This PR fixes this in the following way:
Testing: WPT tests will catch any issues for the dom parts and the net parts are used throughout almost all tests.