script: propagate &mut JSContext in EventTarget::fire_event_with_params#44482
Merged
TimvdLippe merged 1 commit intoservo:mainfrom Apr 27, 2026
Merged
Conversation
servo-highfive
added
the
S-awaiting-review
Contributor
Author
|
ping @Gae24 |
Contributor
This PR already introduce a couple of |
TimvdLippe
requested changes
Apr 25, 2026
Contributor
TimvdLippe
left a comment
TimvdLippe
left a comment
There was a problem hiding this comment.
Seems like we are close to making this happen, exciting! Still, looks like we need at least two more preparation PRs before we can make this one stick.
Contributor
There was a problem hiding this comment.
Same here, this first requires a PR to add the cx to this method.
servo-highfive
added
S-needs-code-changes
pull Bot
pushed a commit
to Haofei/servo
that referenced
this pull request
Apr 25, 2026
…ervo#44498) Propagate `&mut JSContext` in `Activatable::activation_behavior` and related call sites. Testing: Successful build is enough Fixes: Part of servo#42638 Opened to reduces the complexity of servo#44482 --------- Signed-off-by: Emmanuel Paul Elom <elomemmanuel007@gmail.com> Signed-off-by: elomscansio <163124154+elomscansio@users.noreply.github.com> Co-authored-by: Gae24 <96017547+Gae24@users.noreply.github.com>
Signed-off-by: Emmanuel Paul Elom <elomemmanuel007@gmail.com>
elomscansio
force-pushed
the
port-EventTarget-fire_event_with_params
branch
from
a18ddae to
c4cdf44
Compare
servo-highfive
added
S-awaiting-review
TimvdLippe
approved these changes
Apr 27, 2026
Contributor
TimvdLippe
left a comment
TimvdLippe
left a comment
There was a problem hiding this comment.
This is an amazing cleanup! Thanks for sticking with us and tackling those unblocking issues we identified.
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagate
&mut JSContextinEventTarget::fire_event_with_paramsand related call sites.Testing: Successful build is enough
Fixes: Part of #42638