layout: Remove some newline-related dead code from shaping#44485
Merged
Conversation
In servo#44436, I neglected to remove some hard line break-related code from the shaping code. This code is effectively dead code now that hard line breaks never make it to this code path, so it can safely be removed. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
servo-highfive
added
the
S-awaiting-review
yezhizhen
approved these changes
Apr 25, 2026
Member
yezhizhen
left a comment
yezhizhen
left a comment
There was a problem hiding this comment.
Looks straightforward to me.
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #44436, I neglected to remove some hard line break-related code from
the shaping code. This code is effectively dead code now that
hard line breaks never make it to this code path, so it can safely be
removed.
Testing: This should not change behavior, so existing tests should suffice.