Skip to content

script: Propagate &mut JSContext to UnderlyingSourceContainer::call_pull_algorithm#44590

Merged
TimvdLippe merged 2 commits into
servo:mainfrom
Gae24:stream-cx
Apr 30, 2026
Merged

script: Propagate &mut JSContext to UnderlyingSourceContainer::call_pull_algorithm#44590
TimvdLippe merged 2 commits into
servo:mainfrom
Gae24:stream-cx

Conversation

@Gae24
Copy link
Copy Markdown
Contributor

@Gae24 Gae24 commented Apr 29, 2026

Changes extracted from call-setup-cx to minimize PR size.

Testing: It compiles
Part of #40600

@Gae24 Gae24 requested a review from gterzian as a code owner April 29, 2026 08:19
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 29, 2026
@Gae24 Gae24 changed the title script: Propagate &mut JSContext in more stream code script: Propagate &mut JSContext to UnderlyingSourceContainer::call_pull_algorithm Apr 29, 2026
…thm`

Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
@Gae24
Copy link
Copy Markdown
Contributor Author

Gae24 commented Apr 29, 2026

Rebased on top of latest changes.

Copy link
Copy Markdown
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a few unrelated changes, which made reviewing a bit harder. Please separate these out in future PRs to make it easier to follow.

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Apr 30, 2026
@TimvdLippe TimvdLippe added this pull request to the merge queue Apr 30, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 30, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 30, 2026
@servo-highfive servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Apr 30, 2026
Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
@servo-highfive servo-highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Apr 30, 2026
@TimvdLippe TimvdLippe added this pull request to the merge queue Apr 30, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 30, 2026
Merged via the queue into servo:main with commit 59773ea Apr 30, 2026
33 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 30, 2026
@Gae24 Gae24 deleted the stream-cx branch May 7, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants