script: propagate &mut JSContext in GlobalScope::report_an_error by elomscansio · Pull Request #44658 · servo/servo

elomscansio · 2026-05-01T09:50:17Z

Propagate &mut JSContext in GlobalScope::report_an_error and related call sites.

Testing: Successful build is enough
Fixes: Part of #42638

Signed-off-by: Emmanuel Paul Elom <elomemmanuel007@gmail.com>

sagudev · 2026-05-01T10:06:18Z

-            value.handle(),
-            can_gc,
-        );
+pub(crate) fn report_pending_exception(cx: &mut js::context::JSContext) {


This function took cx and InRealm so now it should take &mut https://doc.servo.org/mozjs/realm/struct.CurrentRealm.html

sagudev · 2026-05-01T16:00:20Z

+    let mut realm = enter_auto_realm(cx, &*global);
+    let cx = &mut realm.current_realm();


because we now get realm we do not need to enter it anymore and we can also move global obtaining down

elomscansio · 2026-05-01T16:01:06Z


+'Console': {
+    'cx': ['Log', 'Clear', 'Debug', 'Info', 'Warn', 'Error', 'Trace']
+},
+


@sagudev Do you know why i'm having this error.

Compiling servo-script-bindings v0.2.0 (/home/elomscansio/Desktop/PROJECTS/SERVO_SETUP/servo/components/script_bindings) Compiling servo-script v0.2.0 (/home/elomscansio/Desktop/PROJECTS/SERVO_SETUP/servo/components/script) error[E0053]: method `Log` has an incompatible type for trait --> components/script/dom/console.rs:716:16 | 716 | fn Log(cx: &mut js::context::JSContext, global: &GlobalScope, messages: Vec<HandleVa... | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `JSContext`, found `&mut js::context::JSContext` | = note: expected signature `fn(script_bindings::script_runtime::JSContext, &globalscope::GlobalScope, Vec<js::rust::Handle<'_, _>>)` found signature `fn(&mut js::context::JSContext, &globalscope::GlobalScope, Vec<js::rust::Handle<'_, _>>)` help: change the parameter type to match the trait | 716 - fn Log(cx: &mut js::context::JSContext, global: &GlobalScope, messages: Vec<HandleValue>) { 716 + fn Log(cx: script_bindings::script_runtime::JSContext, global: &GlobalScope, messages: Vec<HandleValue>) { | error[E0053]: method `Debug` has an incompatible type for trait --> components/script/dom/console.rs:741:18 | 741 | fn Debug(cx: &mut js::context::JSContext, global: &GlobalScope, messages: Vec<Handle... | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `JSContext`, found `&mut js::context::JSContext` | = note: expected signature `fn(script_bindings::script_runtime::JSContext, &globalscope::GlobalScope, Vec<js::rust::Handle<'_, _>>)` found signature `fn(&mut js::context::JSContext, &globalscope::GlobalScope, Vec<js::rust::Handle<'_, _>>)` help: change the parameter type to match the trait | 741 - fn Debug(cx: &mut js::context::JSContext, global: &GlobalScope, messages: Vec<HandleValue>) { 741 + fn Debug(cx: script_bindings::script_runtime::JSContext, global: &GlobalScope, messages: Vec<HandleValue>) { | error[E0053]: method `Info` has an incompatible type for trait --> components/script/dom/console.rs:752:17 | 752 | fn Info(cx: &mut js::context::JSContext, global: &GlobalScope, messages: Vec<HandleV... | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `JSContext`, found `&mut js::context::JSContext` | = note: expected signature `fn(script_bindings::script_runtime::JSContext, &globalscope::GlobalScope, Vec<js::rust::Handle<'_, _>>)` found signature `fn(&mut js::context::JSContext, &globalscope::GlobalScope, Vec<js::rust::Handle<'_, _>>)` help: change the parameter type to match the trait | 752 - fn Info(cx: &mut js::context::JSContext, global: &GlobalScope, messages: Vec<HandleValue>) { 752 + fn Info(cx: script_bindings::script_runtime::JSContext, global: &GlobalScope, messages: Vec<HandleValue>) { | error[E0053]: method `Warn` has an incompatible type for trait --> components/script/dom/console.rs:763:17 | 763 | fn Warn(cx: &mut js::context::JSContext, global: &GlobalScope, messages: Vec<HandleV... | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `JSContext`, found `&mut js::context::JSContext` | = note: expected signature `fn(script_bindings::script_runtime::JSContext, &globalscope::GlobalScope, Vec<js::rust::Handle<'_, _>>)` found signature `fn(&mut js::context::JSContext, &globalscope::GlobalScope, Vec<js::rust::Handle<'_, _>>)` help: change the parameter type to match the trait | 763 - fn Warn(cx: &mut js::context::JSContext, global: &GlobalScope, messages: Vec<HandleValue>) { 763 + fn Warn(cx: script_bindings::script_runtime::JSContext, global: &GlobalScope, messages: Vec<HandleValue>) { | error[E0053]: method `Error` has an incompatible type for trait --> components/script/dom/console.rs:774:18 | 774 | fn Error(cx: &mut js::context::JSContext, global: &GlobalScope, messages: Vec<Handle... | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `JSContext`, found `&mut js::context::JSContext` | = note: expected signature `fn(script_bindings::script_runtime::JSContext, &globalscope::GlobalScope, Vec<js::rust::Handle<'_, _>>)` found signature `fn(&mut js::context::JSContext, &globalscope::GlobalScope, Vec<js::rust::Handle<'_, _>>)` help: change the parameter type to match the trait | 774 - fn Error(cx: &mut js::context::JSContext, global: &GlobalScope, messages: Vec<HandleValue>) { 774 + fn Error(cx: script_bindings::script_runtime::JSContext, global: &GlobalScope, messages: Vec<HandleValue>) { | error[E0053]: method `Trace` has an incompatible type for trait --> components/script/dom/console.rs:785:18 | 785 | fn Trace(cx: &mut js::context::JSContext, global: &GlobalScope, messages: Vec<Handle... | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `JSContext`, found `&mut js::context::JSContext` | = note: expected signature `fn(script_bindings::script_runtime::JSContext, &globalscope::GlobalScope, Vec<js::rust::Handle<'_, _>>)` found signature `fn(&mut js::context::JSContext, &globalscope::GlobalScope, Vec<js::rust::Handle<'_, _>>)` help: change the parameter type to match the trait | 785 - fn Trace(cx: &mut js::context::JSContext, global: &GlobalScope, messages: Vec<HandleValue>) { 785 + fn Trace(cx: script_bindings::script_runtime::JSContext, global: &GlobalScope, messages: Vec<HandleValue>) { | For more information about this error, try `rustc --explain E0053`. error: could not compile `servo-script` (lib) due to 6 previous errors Timing report saved to /home/elomscansio/Desktop/PROJECTS/SERVO_SETUP/servo/target/cargo-timings/cargo-timing-20260501T155032.617163731Z.html Failed in 0:01:36

Hm, this will might be a problem in codegen, I will check what is wrong tomorrow.

Aha, you need to write lowercase console:

Suggested change

'Console': {

'cx': ['Log', 'Clear', 'Debug', 'Info', 'Warn', 'Error', 'Trace']

},

'console': {

'cx': ['Log', 'Clear', 'Debug', 'Info', 'Warn', 'Error', 'Trace']

},

because the trait is consoleMethods. This is one of the rarest cases where trait is lowercased.

…m instead of JSContext Signed-off-by: Emmanuel Paul Elom <elomemmanuel007@gmail.com>

sagudev · 2026-05-01T16:01:52Z

@@ -429,9 +432,9 @@ pub(crate) fn take_and_report_pending_exception_for_api(

    let return_value = javascript_error_info_from_error_info(cx, &error_info, value.handle());
    GlobalScope::from_safe_context(cx.into(), in_realm).report_an_error(


Unrelated, but we should used GlobalScope::from_current_realm here, so we can avoid in realm proof.

sagudev · 2026-05-01T16:05:18Z

+        let window = &mut document.window();
+        let global = window.global();
+
+        let mut realm = enter_auto_realm(cx, &*global);


before we entered realm of window so we should keep doing this:

Suggested change

let window = &mut document.window();

let global = window.global();

let mut realm = enter_auto_realm(cx, &*global);

let window = document.window();

let mut realm = enter_auto_realm(cx, window);

sagudev · 2026-05-01T16:06:18Z

        let url = cformat!("{}", handler.url);
-        let options = unsafe { CompileOptionsWrapper::new_raw(*cx, url, handler.line as u32) };
+        let options =
+            unsafe { CompileOptionsWrapper::new_raw(cx.raw_cx(), url, handler.line as u32) };


Suggested change

unsafe { CompileOptionsWrapper::new_raw(cx.raw_cx(), url, handler.line as u32) };

CompileOptionsWrapper::new(cx, url, handler.line as u32);

sagudev · 2026-05-01T16:07:32Z

-    let mut ids = unsafe { IdVector::new(*cx) };
+    let mut ids = unsafe { IdVector::new(cx.raw_cx()) };
    if !unsafe {
        GetPropertyKeys(


In such cases we should use functions from wrappers2 if possible: https://doc.servo.org/mozjs/rust/wrappers2/fn.GetPropertyKeys.html

This goes for many methods in this file that need cx.raw_cx().

sagudev · 2026-05-01T16:19:29Z

+    let mut cx = unsafe { script_bindings::script_runtime::temp_cx() };
+    let cx = &mut cx;


NOTE-TO-SELF: This will likely need to be perma cx, tho I think we should get it from SM.

TimvdLippe · 2026-05-12T05:42:46Z

@elomscansio what's the ststus of this PR? The migration was going along nicely and we would love to continue going. Is there anything we can help you with or is life busy in general that you want to revisit this later?

script: propagate &mut JSContext in GlobalScope::report_an_error

67f4165

Signed-off-by: Emmanuel Paul Elom <elomemmanuel007@gmail.com>

elomscansio requested review from gterzian and yezhizhen as code owners May 1, 2026 09:50

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label May 1, 2026

elomscansio mentioned this pull request May 1, 2026

Port CanGC/InRealm methods to use &mut JSContext/CurrentRealm #42638

Open

sagudev requested changes May 1, 2026

View reviewed changes

sagudev reviewed May 1, 2026

View reviewed changes

elomscansio commented May 1, 2026

View reviewed changes

refactor(scripts): update report_pending_exception to use CurrentReal…

2fcc799

…m instead of JSContext Signed-off-by: Emmanuel Paul Elom <elomemmanuel007@gmail.com>

elomscansio force-pushed the port-GlobalScope-report_an_error branch from 38052f4 to 2fcc799 Compare May 1, 2026 16:06

sagudev reviewed May 1, 2026

View reviewed changes

servo-highfive added the S-needs-rebase There are merge conflict errors. label May 4, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

script: propagate &mut JSContext in GlobalScope::report_an_error#44658

script: propagate &mut JSContext in GlobalScope::report_an_error#44658
elomscansio wants to merge 2 commits into
servo:mainfrom
elomscansio:port-GlobalScope-report_an_error

elomscansio commented May 1, 2026

Uh oh!

sagudev May 1, 2026

Uh oh!

sagudev May 1, 2026

Uh oh!

elomscansio May 1, 2026

Uh oh!

sagudev May 1, 2026

Uh oh!

sagudev May 4, 2026

Uh oh!

sagudev May 1, 2026

Uh oh!

sagudev May 1, 2026

Uh oh!

sagudev May 1, 2026

Uh oh!

sagudev May 1, 2026

Uh oh!

sagudev May 1, 2026

Uh oh!

TimvdLippe commented May 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		let mut realm = enter_auto_realm(cx, &*global);
		let cx = &mut realm.current_realm();

		@@ -429,9 +432,9 @@ pub(crate) fn take_and_report_pending_exception_for_api(

		let return_value = javascript_error_info_from_error_info(cx, &error_info, value.handle());
		GlobalScope::from_safe_context(cx.into(), in_realm).report_an_error(

	unsafe { CompileOptionsWrapper::new_raw(cx.raw_cx(), url, handler.line as u32) };
	CompileOptionsWrapper::new(cx, url, handler.line as u32);

		let mut cx = unsafe { script_bindings::script_runtime::temp_cx() };
		let cx = &mut cx;

Uh oh!

Conversation

elomscansio commented May 1, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TimvdLippe commented May 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants