layout: Root nodes which correspond to accessibility tree nodes.#44949
Draft
alice wants to merge 10 commits into
Draft
layout: Root nodes which correspond to accessibility tree nodes.#44949alice wants to merge 10 commits into
alice wants to merge 10 commits into
Conversation
Signed-off-by: Alice Boxhall <alice@igalia.com> Co-authored-by: Delan Azabani <dazabani@igalia.com>
Signed-off-by: delan azabani <dazabani@igalia.com>
Signed-off-by: delan azabani <dazabani@igalia.com>
Co-authored-by: Alice Boxhall <alice@igalia.com> Signed-off-by: delan azabani <dazabani@igalia.com>
Also, remove stale/fresh logic from get_or_create_node(), and add an integrity check for disjointness of new_nodes and stale_nodes. Signed-off-by: Alice Boxhall <alice@igalia.com>
Co-authored-by: Delan Azabani <dazabani@igalia.com> Signed-off-by: Alice Boxhall <alice@igalia.com>
Signed-off-by: Alice Boxhall <alice@igalia.com>
Co-authored-by: delan azabani <dazabani@igalia.com> Signed-off-by: Alice Boxhall <alice@igalia.com>
Signed-off-by: Alice Boxhall <alice@igalia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we use OpaqueNodes to look up accessibility nodes, we want to ensure OpaqueNodes aren't reused before their corresponding accessibility nodes are pruned from the tree.
This change modifies
AccessibilityTree::update_tree()to return, in addition to the TreeUpdate, two vectors containing OpaqueNodes which have been newly added to and removed from the accessibility tree, respectively. These vectors are stored on theLayoutThreaduntildrain_new_nodes_for_accessibility()anddrain_stale_nodes_for_accessibility()are called, which should happen as soon as possible after the reflow has finished so that the nodes can be rooted.These vectors are used to maintain a HashMap of OpaqueNode to
Dom<Node>on Document.Testing: Keeps existing behaviour; not sure how to test the new behaviour.
Currently includes changes from #44801.