Skip to content

Add a Device::resize_bound_surface API#362

Merged
jdm merged 1 commit into
servo:mainfrom
mrobinson:resize-bound-surface
Jun 7, 2026
Merged

Add a Device::resize_bound_surface API#362
jdm merged 1 commit into
servo:mainfrom
mrobinson:resize-bound-surface

Conversation

@mrobinson
Copy link
Copy Markdown
Member

Much like #361, this change adds a Device::resize_bound_surface API so
that widget surfaces can be resized without introducing a spurious
eglMakeCurrent with NO_SURFACE. This will greatly improve resizing
behavior in Servo.

@mrobinson mrobinson mentioned this pull request Jun 7, 2026
@mrobinson mrobinson force-pushed the resize-bound-surface branch 2 times, most recently from 655f198 to 11c09b1 Compare June 7, 2026 07:29
Comment thread src/platform/macos/cgl/surface.rs Outdated
}

/// Resizes a widget surface.
pub fn resize_inner(
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be pub(crate)?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! I will correct that before landing.

@mrobinson mrobinson force-pushed the resize-bound-surface branch from 11c09b1 to b8b15e1 Compare June 7, 2026 10:51
Much like servo#361, this change adds a `Device::resize_bound_surface` API so
that widget surfaces can be resized without introducing a spurious
`eglMakeCurrent` with `NO_SURFACE`. This will greatly improve resizing
behavior in Servo.

Signed-off-by: Martin Robinson <martin@abandonedwig.info>
@mrobinson mrobinson force-pushed the resize-bound-surface branch from b8b15e1 to 0cfb476 Compare June 7, 2026 11:23
@mrobinson mrobinson enabled auto-merge June 7, 2026 11:23
@mrobinson mrobinson added this pull request to the merge queue Jun 7, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 7, 2026
@jdm jdm added this pull request to the merge queue Jun 7, 2026
Merged via the queue into servo:main with commit c1adea3 Jun 7, 2026
56 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants