Clean up X11 EGLDisplay when NativeConnectionWrapper created it#364
Merged
Conversation
mrobinson
force-pushed
the
clean-up-egl-display
branch
from
a0617f2 to
b1e9925
Compare
This changes fixes and issue where creating an `EGLDisplay` could return a version against an invalid X11 `Display`. It seems that Mesa internally caches live `EGLDisplay`s against the X11 `Display` pointer. If we close the X11 Display without terminating the `EGLDisplay`, a fresh X11 `Display` with the same pointer address can return the defunct `EGLDisplay`. This change fixes that issue by no longer leaking our `EGLDisplay`. Signed-off-by: Martin Robinson <mrobinson@abandonedwig.info>
mrobinson
force-pushed
the
clean-up-egl-display
branch
from
b1e9925 to
fcce18d
Compare
mrobinson
changed the title
EGLDisplay when NativeConnectionWrapper created it
jdm
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes fixes an issue where creating an
EGLDisplaycould returna version against an invalid X11
Display. It seems that Mesa internallycaches live
EGLDisplays against the X11Displaypointer. If we closethe X11 Display without terminating the
EGLDisplay, a fresh X11Displaywith the same pointer address can return the defunctEGLDisplay. This change fixes that issue by no longer leaking ourEGLDisplay.