Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upClear draw buffer after creation and resize. #75
Conversation
|
I don't think we can call Otherwise we're changing the underlying state of the GL context under the hood, and I while I think What do you think? |
|
Yeah, that can be a problem in the resize method. It's not a problem in the init because a transparent color is the default one. We can restore the ClearColor from WebGL (we are restoring scissor value too now to mach the Spec). |
|
Ok, r=me with that in Servo then. |
|
Ok, please bump version ;) |
|
Done :P. Next time feel free to PR the version bump too. |
MortimerGoro commentedNov 30, 2016
I've been working on fixing the scissor test for servo/servo#14075 and found that the GLContexts are not cleared after creation. That's why that test is failing now (after fixing what the spec says about scissor).
I'm adding the clear changes here because I think that clearing the created framebuffer is a good default for any project. I had a lot of problems in the past with buggy Adreno GPUs on Android because of this. A initial clear is a safeguard to avoid problems. Some Adrenos were such bad that even required clearing the Depth/Stencil even if the buffer is neither created and used.