Move all layer tree operations to a ScrollTree struct #754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it easier to introduce the idea of reference frames into WebRender. This should not change behavior.
Member
|
This looks good, and I've tested scrolling on a number of different sites. |
Member
|
@bors-servo r+ |
Contributor
|
📌 Commit 5687f7d has been approved by |
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Jan 19, 2017
Move all layer tree operations to a ScrollTree struct This will make it easier to introduce the idea of reference frames into WebRender. This should not change behavior. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/754) <!-- Reviewable:end -->
Member
Author
|
Thanks! |
Contributor
|
☀️ Test successful - status-travis |
Merged
kvark
reviewed
Jan 19, 2017
| } | ||
|
|
||
| scrolled_a_layer | ||
| self.scroll_tree.scroll(scroll_location, cursor, phase,) |
Member
Author
There was a problem hiding this comment.
Yes! I will fix this in a followup.
| &DEFAULT_SCROLLBAR_COLOR, | ||
| PrimitiveFlags::Scrollbar(self.root_scroll_layer_id.unwrap(), | ||
| 4.0)); | ||
| context.builder.add_solid_rectangle( |
Member
There was a problem hiding this comment.
isn't the new formatting (see below) against the style guidelines?
Member
Author
There was a problem hiding this comment.
I'm not sure, but the PrimitiveFlags::Scrollbar(self.root_scroll_layer_id.unwrap(), line wouldn't fit within the line length limit any other way.
Member
There was a problem hiding this comment.
ok, I don't know what the guidelines are for this case then
| pub fn collect_layers_bouncing_back(&self) | ||
| -> HashSet<ScrollLayerId, BuildHasherDefault<FnvHasher>> { | ||
| let mut layers_bouncing_back = HashSet::with_hasher(Default::default()); | ||
| for (scroll_layer_id, layer) in self.layers.iter() { |
Member
There was a problem hiding this comment.
nit (unrelated to the PR): we could do something fancy like
self.layers.iter()
.filter(|(_, layer)| layer.scrolling.bouncing_back)
.map(|(id, _)| *id)
.collect()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it easier to introduce the idea of reference frames
into WebRender. This should not change behavior.
This change is