Add scrolling support to wrench #806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
jrmuizel
approved these changes
Jan 30, 2017
This parameter will instruct servo to either discard or preserve frame data for the given pipeline. Discarded frame data includes scroll positions and the currently scrolling layer. This makes it so that unrelated frames won't inadvertently share scroll positions.
mrobinson
force-pushed
the
wrench-scrolling
branch
from
b9b4c80 to
1884cd0
Compare
Member
Author
|
Looks like I inadvertently broke the sample app. I've fixed that now. @jrmuizel, is it okay to send this to bors again? |
This change adds scroll layer as an item type in wrench and allows setting a scroll offset for them as well as the root. Additionally, some basic scrolling tests are included to help establish some basic principles of scrolling behavior.
mrobinson
force-pushed
the
wrench-scrolling
branch
from
1884cd0 to
5233df6
Compare
Member
Author
|
One more quick update to the PR that properly supports writing scroll-policy in the YAML writer. |
Member
Author
|
The changes from the originally reviewed patch were very minor, so I feel pretty confident landing this to avoid timezone induced +1 day lag. |
Member
Author
|
@bors-servo r=jrmuizel |
Contributor
|
📌 Commit 5233df6 has been approved by |
Contributor
|
⚡ Test exempted - status |
bors-servo
pushed a commit
that referenced
this pull request
Jan 30, 2017
Add scrolling support to wrench This PR includes two commits: - The first modifies the API of WebRender to instruct it to throw away scrolling offsets during changes to unrelated display lists. In the future this will need to be more complicated to handle back and forward navigation. - The second adds scroll layers and scroll-offset to wrench itself in order to allow tests of scrolling behavior. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/806) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two commits:
This change is