Fix currently scrolling layer id caching #800
Conversation
gterzian
force-pushed
the
fix_current_scroll_layer_caching
branch
3 times, most recently
from
435b776 to
f954c94
Compare
gterzian
force-pushed
the
fix_current_scroll_layer_caching
branch
from
f954c94 to
41c7e3f
Compare
|
@jdm So I am still unable to reproduce the panic. If you can do so consistently, could I please ask you to test if this fixes it? This one requires building with servo/servo#15111 |
|
This seems OK to me - but let's double check with @mrobinson first. |
|
@glennw Thank you. I changed the variables names a bit for clarity... |
|
I think that we will need to change the API in order to let WebRender know when a batch of scroll layers doesn't have any correspondence with the previous one. I need that for a PR that I'm working on, but a decent fallback here makes sense as well. Thanks! |
|
The new API is here: #806 This patch should work fine in tandem with that. |
|
@bors-servo r+ |
|
📌 Commit 4a5403c has been approved by |
Fix currently scrolling layer id caching Fix for servo/servo#15251 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/800) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
|
@glennw @mrobinson Thanks for your help, I will also take a look at the new API, and the scroll testing capabilities of Wrench. Sorry I didn't squash that one extra commit, I guess it's not the end of the world... |
|
No worries, thanks for the fix! |
4 participants
Fix for servo/servo#15251
This change is