Pass GlyphKey to platform font contexts #811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
☔ The latest upstream changes (presumably #808) made this pull request unmergeable. Please resolve the merge conflicts. |
kvark
approved these changes
Jan 31, 2017
Member
kvark
left a comment
kvark
left a comment
There was a problem hiding this comment.
Thanks, and sorry about the delay!
Looks fairly straightforward. Please rebase, and we'll proceed.
Contributor
Author
|
Will rebase after #798 - Sorry, so many PRs just conflict upon each other so I'm gonna try to do one at a time instead of rebasing everyday. |
Contributor
Author
|
@bors-servo retry . Build error due to CI issues. |
Contributor
|
@changm: 🔑 Insufficient privileges: and not in try users |
Contributor
Author
Member
|
@bors-servo r+ |
Contributor
|
📌 Commit 552a849 has been approved by |
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Feb 3, 2017
Pass GlyphKey to platform font contexts This might be too much to review for now. Doh. Maybe easier to just review the single commit? a311e1d <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/811) <!-- Reviewable:end -->
Contributor
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be too much to review for now. Doh. Maybe easier to just review the single commit? a311e1d
This change is