chore(deps): update @atlaskit/inline-message to v15.6.11#2882
Merged
Conversation
✅ Deploy Preview for atlassify canceled.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR contains the following updates:
15.6.10→15.6.11Release Notes
atlassian/atlassian-frontend-mirror (@atlaskit/inline-message)
v15.6.11Patch Changes
7250582895c0b-Top-layer adoption work behind the
platform-dst-top-layerfeature flag. Public adopter APIs areintentionally kept narrow while the top-layer API surface settles, with one exception called out
below.
Highlights:
[along, away]legacy popper offset through to the new top-layerplacement.offsetAPI (viafromLegacyPlacement). Previously only theawayaxis wasforwarded, which dropped the
alongoffset for consumers ofPopup,PopupSelect,Spotlight, andTooltipwhenplatform-dst-top-layeris enabled.dialogHeightanddialogWidthfrom the removed utils module in@atlaskit/modal-dialog.Public API:
@atlaskit/tooltip(minor): add an optionaltestId?: stringfield toTriggerProps.This is additive (no existing prop changes shape). Required because
@atlaskit/button/new(andother
Pressable-backed primitives) overwritedata-testidfrom spread, so the legacy(triggerProps as any)['data-testid']workaround is silently absorbed by those consumers. Atyped
testIdfield flows through their owntestIddestructure instead, restoringdata-testidpropagation onto the rendered trigger element.@atlaskit/popup,@atlaskit/dropdown-menu(patch): no public type changes. Wideraria-haspopupunions that the FF-on path produces are bridged at the package boundary into@atlaskit/top-layerwith localisedFUDGE(top-layer-api)casts, documented inpackages/design-system/top-layer/notes/decisions/migration-roadmap.md("Open API decisionsdeferred to a follow-up PR"). They will be widened in a follow-up
minorPR once the top-layerAPI is committed.
@atlaskit/modal-dialog,@atlaskit/select,@atlaskit/spotlight(
patch/minor): no public type changes; bug fixes only.Merge-readiness fixes (FF-on test wiring + adopter behavior):
@atlaskit/popup(minor): wire the compositionalPopupContentto delegate toPopupContentTopLayerwhenplatform-dst-top-layeris enabled. Previously only the legacyPopupcomponent had the FF branch, leaving consumers of the compositional API on the legacypopper path.
@atlaskit/select(minor): add anonClickhandler to thePopupSelecttop-layertrigger so clicks open/close the menu (mirrors the legacy global click handler in
popup-select.tsx). Add explicit Escape handling on the menu'sonKeyDownso the menu closesand focus returns to the trigger.
@atlaskit/top-layer(patch): the<dialog>rendered by the Dialog primitive now setsaria-modal="true"explicitly. Modern browsers infer modal semantics from.showModal()butsome assistive tech still keys off the explicit attribute.
@atlaskit/top-layer(patch): guarduse-anchor-positioningagainst environments whereResizeObserveris not defined (e.g. jest'snodeenvironment, used by the post-office testsuite). The observer is used to wait for the popover's first valid layout before measuring;
consumers in non-DOM jest environments now get a no-op observer and the scroll/resize listeners
still apply if the host environment polyfills
showPopover. Real browsers always haveResizeObserver.@atlaskit/modal-dialog(patch): on the FF-on path, drop thetabIndex={-1}(and unused:focus-visibleoutline) from the modal content wrapper. The native<dialog>.showModal()focus-delegate algorithm picks the first focusable descendant (including
tabindex=-1), and thewrapper was hijacking initial focus from the close button. Also honor
shouldReturnFocus={ref}on the FF-on path (an unmount-cleanup focuses the ref after
dialog.close()so it overrides thebrowser's automatic return-to-trigger). Boolean
shouldReturnFocus={false}is not yet honoredon the FF-on path — see
top-layer/notes/merge-blockers.md.@atlaskit/datetime-picker(patch): on the FF-on path, setmode="manual"on thePopup.Contentrendered by bothinternal/menu-top-layer.tsx(date-picker calendar) andinternal/fixed-layer-menu-top-layer.tsx(time-picker menu). With the defaultmode="auto",the same click event that opens the menu (which targets the react-select combobox input —
outside the popover element) bubbles to the browser's native popover light-dismiss handler and
immediately closes the menu. react-select / DateTimePicker already own outside-click and Esc
dismissal via their own state, so opting out of the native auto-dismiss is the correct
integration. Also extend the existing Esc → trigger-focus restoration in
components/date-picker.tsxto the FF-on path (manual mode disables the browser's built-infocus return, and the legacy code path was already handling this for itself behind an FF
negation).
@atlaskit/popup(no public API change): no source changes — only FF-on Playwrightspec/example fixes drove the suite from 21/3/2 to 27/0/0. Notable: the two
test.fixme'dnested-popover cases were not browser limitations;
popover="auto"chains correctly via DOMancestry (the original fixmes had the wrong testId selector). Added
testIdprops to twoexamples (
16-popup-with-a11y-props,18-should-fit-container) so default-shape tests canreach the trigger.
popup,select,datetime-picker,inline-dialog,inline-message, andmodal-dialog: selector updates to match the newtop-layer testId convention (
${testId}--content,[role="dialog"][aria-label="calendar"]),per-spec
skipAxeCheck()for example-level color-contrast violations unrelated to themigration, and focus assertions adjusted to match native
<dialog>/Popup.Contentauto-focussemantics (focus lands on the first focusable child, not the dialog container itself).
@atlassian/capacity-planning-capacity-graph,@atlaskit/color-picker,@atlassian/timeline-table,@atlassian/global-side-navigation(patch): scopefgmocks in unit tests so
platform-dst-top-layerreturnsfalse. JSDOM does not implement thenative Popover API (
showPopover/hidePopover/toggleevents), so leaving the gate ON in unittests caused popover content to remain in the DOM after close and broke close-behaviour
assertions. Browser coverage for the FF-on path is provided by the Playwright suites listed
above.
@atlaskit/dropdown-menu(no public API change): test/example-only fixes for the FF-onPlaywright suite. Added
role="menuitem"to the nested-triggerButtonIteminexamples/93-testing-nested-keyboard-navigation-top-layer.tsxto satisfy axe'saria-required-childrenrule on the parent menu. Added atest.beforeEach(skipAxeCheck)todropdown-menu.spec.tsx(FF-on suite) for example-levelcolor-contrastviolations on thepre-existing
color.text.selected/color.background.selectedtoken pair (3.91:1). Replaced adeadlocking
await expect(moveItem).not.toBeFocused()pre-open assertion (Playwright'sauto-wait blocks 5s on the absent element) with
await expect(moveItem).not.toBeVisible().Suite result: 22/22 passing.
Updated dependencies
Configuration
📅 Schedule: (UTC)
* 0-3 * * *)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.