-
Notifications
You must be signed in to change notification settings - Fork 0
Fix/button dark theme #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request introduces dark theme styles for the main and secondary buttons. The changes ensure that the buttons are visible and consistent with the dark theme's color palette. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @SaeeDawod - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| background-color: #346eee; | ||
| color: #ffffff; | ||
| } | ||
|
|
||
| [data-theme='dark'] .secondaryButton { | ||
| background-color: transparent; | ||
| color: #ffffff; | ||
| border-color: #ffffff; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Consider using CSS variables for colors instead of hard-coded hex values
This would improve maintainability and ensure consistency across the theme system.
Suggested implementation:
:root {
--primary-button-color: #346eee;
--text-color-light: #ffffff;
}
.hero .hero-subtitle {
text-align: center;
}
[data-theme='dark'] .mainButton {
[data-theme='dark'] .mainButton {
background-color: var(--primary-button-color);
color: var(--text-color-light);
}
[data-theme='dark'] .secondaryButton {
background-color: transparent;
color: var(--text-color-light);
border-color: var(--text-color-light);
Note: You might want to:
- Add more CSS variables for other colors used in the light theme
- Consider adding semantic variable names for specific use cases (e.g.
--button-primary-bg,--button-text) - Organize the CSS variables by theme if there are more theme-specific colors
Summary by Sourcery
Bug Fixes: