Skip to content

Fix/button dark theme #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bl0up merged 2 commits into from
Jan 22, 2025
Merged

Fix/button dark theme #135

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
636cb60
fix: button colors in dark theme
saeeddawod Jan 22, 2025
d029f77
removed imporant from css
saeeddawod Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions theme/styles.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,3 +540,14 @@ h3 {
.hero .hero-subtitle {
text-align: center;
}

[data-theme='dark'] .mainButton {
background-color: #346eee;
color: #ffffff;
}

[data-theme='dark'] .secondaryButton {
background-color: transparent;
color: #ffffff;
border-color: #ffffff;
Comment on lines +545 to +552
Copy link

@sourcery-ai sourcery-ai bot Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Consider using CSS variables for colors instead of hard-coded hex values

This would improve maintainability and ensure consistency across the theme system.

Suggested implementation:

:root {
  --primary-button-color: #346eee;
  --text-color-light: #ffffff;
}

.hero .hero-subtitle {
  text-align: center;
}

[data-theme='dark'] .mainButton {


[data-theme='dark'] .mainButton {
  background-color: var(--primary-button-color);
  color: var(--text-color-light);
}

[data-theme='dark'] .secondaryButton {
  background-color: transparent;
  color: var(--text-color-light);
  border-color: var(--text-color-light);

Note: You might want to:

  1. Add more CSS variables for other colors used in the light theme
  2. Consider adding semantic variable names for specific use cases (e.g. --button-primary-bg, --button-text)
  3. Organize the CSS variables by theme if there are more theme-specific colors

}