Skip to content

add sf vm ssh#107

Merged
coffinsfcompute merged 1 commit into
mainfrom
coffin/ssh
Apr 11, 2025
Merged

add sf vm ssh#107
coffinsfcompute merged 1 commit into
mainfrom
coffin/ssh

Conversation

@coffinsfcompute
Copy link
Copy Markdown
Contributor

No description provided.

@semanticdiff-com
Copy link
Copy Markdown

semanticdiff-com Bot commented Apr 4, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  deno.lock Unsupported file format
  package.json  0% smaller
  src/helpers/urls.ts  0% smaller
  src/lib/ssh.ts  0% smaller
  src/lib/vm.ts  0% smaller

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

The PR integrates SSH support into the VM commands by registering a new ssh subcommand and updating associated API endpoints and dependencies.

  • In src/lib/vm.ts, the SSH command is registered alongside other VM subcommands.
  • src/lib/ssh.ts introduces SSH connection logic with manual escaping and a prefixed ssh:// destination which might impact compatibility.
  • src/helpers/urls.ts now defines the vms_ssh_get endpoint.
  • package.json includes new dependencies (@alphahydrae/exec, shescape) to support SSH functionality.

4 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

Comment thread src/lib/ssh.ts
Comment thread src/lib/ssh.ts
@coffinsfcompute coffinsfcompute force-pushed the coffin/ssh branch 2 times, most recently from 7871f11 to 57d3a4b Compare April 4, 2025 18:25
@coffinsfcompute
Copy link
Copy Markdown
Contributor Author

I thought about feature flagging this, but the whole VM set up is already feature flagged so this seems fine imo.

@coffinsfcompute coffinsfcompute merged commit 85577a2 into main Apr 11, 2025
1 check passed
coffinsfcompute added a commit that referenced this pull request Apr 11, 2025
This reverts commit 85577a2.
coffinsfcompute added a commit that referenced this pull request Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant