Skip to content

feat: [PRODUCT-503] [PRODUCT-504] show helpful messages during VM scheduling and startup#167

Merged
sigmachirality merged 3 commits into
mainfrom
dt/vm-startup-message
Jul 15, 2025
Merged

feat: [PRODUCT-503] [PRODUCT-504] show helpful messages during VM scheduling and startup#167
sigmachirality merged 3 commits into
mainfrom
dt/vm-startup-message

Conversation

@sigmachirality
Copy link
Copy Markdown
Member

@sigmachirality sigmachirality commented Jul 15, 2025

When a VM is awaiting scheduling:
image

When a user has a VM less than 10 minutes old:
image

Additionally, adds --json flag support.
Screenshot 2025-07-14 at 11 27 47 PM

@semanticdiff-com
Copy link
Copy Markdown

semanticdiff-com Bot commented Jul 15, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  src/lib/vm.ts  16% smaller

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR enhances the VM listing command by adding informative messages to guide users during VM startup and scheduling phases. The changes improve user experience by:

  1. Adding clear messages about VM scheduling status
  2. Showing helpful information for VMs less than 10 minutes old
  3. Implementing color-coded status indicators
  4. Adding example commands after listing VMs
  5. Providing better error handling with specific status codes

These changes integrate well with the existing VM management functionality in the CLI, addressing common user confusion around VM provisioning times and startup states. The code modifications follow the established patterns in the codebase for handling API responses and displaying information to users.

Confidence score: 4/5

  1. This PR is safe to merge with minor monitoring recommended
  2. Score based on low-risk UI improvements with good error handling, though new status checks could benefit from additional edge case testing
  3. Files needing attention:
    • src/lib/vm.ts: Verify edge cases for VM age calculation and status detection logic

1 file reviewed, 1 comment
Edit PR Review Bot Settings | Greptile

Comment thread src/lib/vm.ts
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@sigmachirality sigmachirality merged commit d783103 into main Jul 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant