feat: [PRODUCT-503] [PRODUCT-504] show helpful messages during VM scheduling and startup#167
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Greptile Summary
This PR enhances the VM listing command by adding informative messages to guide users during VM startup and scheduling phases. The changes improve user experience by:
- Adding clear messages about VM scheduling status
- Showing helpful information for VMs less than 10 minutes old
- Implementing color-coded status indicators
- Adding example commands after listing VMs
- Providing better error handling with specific status codes
These changes integrate well with the existing VM management functionality in the CLI, addressing common user confusion around VM provisioning times and startup states. The code modifications follow the established patterns in the codebase for handling API responses and displaying information to users.
Confidence score: 4/5
- This PR is safe to merge with minor monitoring recommended
- Score based on low-risk UI improvements with good error handling, though new status checks could benefit from additional edge case testing
- Files needing attention:
- src/lib/vm.ts: Verify edge cases for VM age calculation and status detection logic
1 file reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a VM is awaiting scheduling:

When a user has a VM less than 10 minutes old:

Additionally, adds

--jsonflag support.