fix: [PRODUCT-503] show user all available zones#168
Merged
Conversation
Contributor
There was a problem hiding this comment.
Greptile Summary
This PR modifies the zones display functionality in the CLI to provide users with visibility into all available infrastructure zones, including those that are currently sold out. The changes include:
- Updating type definitions to be more precise (
ZonesListResponsetype now uses a literal "list") - Removing the retired zones filter that previously hid certain zones from users
- Making the CLI documentation more dynamic by using the first actually available zone in examples instead of hardcoding 'alamo'
This change improves transparency by giving users complete information about all zones in the system, allowing them to make better-informed decisions about resource allocation.
Confidence score: 4/5
- This PR is safe to merge with minimal risk of breaking existing functionality
- The changes are straightforward, well-typed, and improve user experience without modifying core business logic
- Pay attention to
src/lib/zones.tsxto ensure the removal of zone filtering doesn't have unintended side effects in zone selection workflows
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to show users all zones even if some are currently sold out.