Skip to content

feat: enhance vm image url expiry date display#198

Merged
sigmachirality merged 3 commits into
mainfrom
cursor/update-vm-image-url-expiry-date-display-a990
Sep 16, 2025
Merged

feat: enhance vm image url expiry date display#198
sigmachirality merged 3 commits into
mainfrom
cursor/update-vm-image-url-expiry-date-display-a990

Conversation

@sigmachirality
Copy link
Copy Markdown
Member

Display human-readable date alongside ISO string for "URL Expiry" in sf vms images list to match sf nodes list --verbose.


Slack Thread

Open in Cursor Open in Web

Co-authored-by: danieltaox <danieltaox@gmail.com>
@cursor
Copy link
Copy Markdown

cursor Bot commented Sep 16, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@semanticdiff-com
Copy link
Copy Markdown

semanticdiff-com Bot commented Sep 16, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  src/lib/vm/image/show.tsx  12% smaller

Co-authored-by: danieltaox <danieltaox@gmail.com>
@sigmachirality sigmachirality changed the title Update vm image url expiry date display feat: enhance vm image url expiry date display Sep 16, 2025
@sigmachirality sigmachirality marked this pull request as ready for review September 16, 2025 20:54
@sigmachirality sigmachirality merged commit 362e30c into main Sep 16, 2025
1 check passed
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR enhances the user experience in the sf vms images list command by improving how URL expiry dates are displayed. The change modifies src/lib/vm/image/show.tsx to show both the ISO string format and a human-readable date with timezone information, bringing consistency with the existing sf nodes list --verbose command.

The implementation adds necessary dayjs plugins for timezone handling (utc and timezone) and leverages the existing formatDate helper function from the codebase. Instead of showing only the raw ISO timestamp like 2025-01-15T10:30:00.000Z, users now see a more comprehensive format: 2025-01-15T10:30:00.000Z (Jan 15 10:30 am EST). This follows the established pattern used throughout the CLI application where dates are displayed with both machine-readable and human-readable formats.

The change integrates seamlessly with the existing codebase architecture by reusing the formatDate utility function and following the same date formatting conventions already established in the nodes list functionality. The timezone display uses dayjs's format method with the "z" specifier to show the timezone abbreviation, providing users with clear context about when their image URLs will expire.

Confidence score: 5/5

  • This PR is safe to merge with minimal risk as it only affects display formatting without changing any business logic
  • Score reflects simple, well-tested date formatting changes using existing utility functions and established patterns
  • No files require special attention as this is a straightforward UI enhancement using proven components

1 file reviewed, no comments

Edit Code Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants