list zones for vms for anyzone autoreserved nodes

[joshi4]

No description provided.

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
src/lib/nodes/list.tsx	14% smaller
src/schema.ts	0% smaller

[joshi4]

• list zones for vms for anyzone autoreserved nodes #228 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[greptile-apps]

Greptile Overview

Greptile Summary

This PR enhances the VM display for auto-reserved nodes by showing zone information at the VM level when the node doesn't have a specific zone assignment.

• Added optional zone field to the node-api_Vm schema to support per-VM zone information
• Extended VMTable component to conditionally display a Zone column based on whether the node has a zone assignment
• For auto-reserved nodes without a specific zone (any-zone nodes), individual VM zones are now displayed in the table
• For reserved nodes with a specific zone, the zone column is hidden to avoid redundancy since zone is already shown at the node level

This change improves visibility into where VMs are running for multi-zone auto-reserved deployments.

Confidence Score: 5/5

• This PR is safe to merge with no identified issues
• The changes are straightforward and well-implemented. The optional zone field is correctly added to the schema, and the UI logic appropriately shows/hides the zone column based on node configuration. Type casting is used appropriately, and the feature is purely additive with no breaking changes.
• No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
src/lib/nodes/list.tsx	5/5	Added conditional zone column display for VMs in auto-reserved nodes without a specific zone assignment
src/schema.ts	5/5	Added optional zone field to VM schema to support zone information for individual VMs

Sequence Diagram

sequenceDiagram
    participant User
    participant CLI
    participant API
    participant VMTable

    User->>CLI: sf nodes ls --verbose
    CLI->>API: client.nodes.list()
    API-->>CLI: nodes with vms data
    Note over API,CLI: VMs now include optional zone field
    CLI->>VMTable: render(<NodesVerboseDisplay>)
    VMTable->>VMTable: Check if node.zone exists
    alt node.zone is null (auto-reserved any-zone)
        VMTable->>VMTable: showZoneColumn = true
        VMTable->>User: Display VM table with Zone column
        Note over VMTable,User: Shows individual VM zones
    else node.zone exists (reserved)
        VMTable->>VMTable: showZoneColumn = false
        VMTable->>User: Display VM table without Zone column
        Note over VMTable,User: Zone displayed at node level only
    end

Loading

[greptile-apps]

_{2 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}