refactor: isFeatureEnabled uses internal feature_flag api#255
Merged
sigmachirality merged 1 commit intomainfrom Mar 18, 2026
Conversation
|
Review changes with |
sigmachirality
changed the title
isFeatureFlagEnabled uses internal feature_flag api
sigmachirality
changed the title
isFeatureFlagEnabled uses internal feature_flag apiisFeatureEnabled uses internal feature_flag api
Member
|
Ideally I would prefer this to live outside of posthog.ts now, but I'm fine with some tech debt as the lifetime of this codebase is numbered |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Move feature flag checks to our internal api.
Description of Changes
We update the impl of isFeatureFlagEnabled to hit /v2/feature_flags/:flag_name to check if a feature_flag is turned on/off for a user.
Caching is left as is.