fix: [PR-1797] suppress migration banner after sf migrate completes#269
Merged
Conversation
Persist `migrated_to_rust_cli: true` in the user's config when `sf migrate` succeeds, and gate the banner on that flag so `sf-old` stops nagging users who've already migrated. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Changed Files
|
Contributor
|
|
Capy auto-review is paused for this organization because the monthly auto-review limit has been reached. Increase the limit or turn it off in billing settings to resume automatic reviews. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
migrated_to_rust_cli: truein~/.sfcompute/configwhensf migratesucceeds.sf-oldstops nagging users who've already migrated.SF_CLI_DISABLE_MIGRATE_BANNERcontinues to work as an explicit override.Test plan
sf migrateon a clean config; verifymigrated_to_rust_cli: trueis written.sf-old <anything>and confirm the migration banner no longer renders.🤖 Generated with Claude Code