Follow Twitter API which again changed the message for already retweeted error #890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In general I'd avoid doing exact string matching on error messages - that's why the API returns error code values as well (they are intended to be immutable). Note that the API response codes page is now here. I'll go ahead and add error 327 over there now for completeness. |
Contributor
Author
|
That's a nice find! It's certainly better to use the machine-readable info whenever available. |
knu
added a commit
to huginn/huginn
that referenced
this pull request
Dec 6, 2017
knu
added a commit
to huginn/huginn
that referenced
this pull request
Aug 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They changed the message again after #875, and the latest message I can observe in my Twitter API failure log is "You have already retweeted this Tweet." The only difference is the last word which got capitalized. (sigh...)
So, I think it's time to drop the message-to-error table based on exact string match.