Remove defaults for optionLabel and optionValue props #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is currently not possible to achieve PrimeVue's default option behaviour for
optionLabelandoptionValue, becausenullandundefinedare always overridden by'label'and'value'respectively. This is PrimeVue's defaultoptionValuebehaviour:This PR removes the defaults to restore PrimeVue's behaviour. This will break applications that rely on this behaviour, so I'm not sure what would be the best way to proceed. I can think of some options:
optionLabeloroptionValueisnullorundefined, so existing applications are notified of the change. Adding a flag to disable the warning would be useful.v-bindinstead of specifying all options separately. Such a change would be suitable for a major release.