Skip to content

Remove defaults for optionLabel and optionValue props #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2024
Merged

Remove defaults for optionLabel and optionValue props #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/formkit/PrimeDropdown.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ const styleClass = computed(() => (context?.state.validationVisible && !context?
:aria-label="attrs.ariaLabel"
:aria-labelledby="attrs.ariaLabelledby"
:options="attrs.options"
:option-label="attrs.optionLabel ?? 'label'"
:option-value="attrs.optionValue ?? 'value'"
:option-label="attrs.optionLabel"
:option-value="attrs.optionValue"
:option-disabled="attrs.optionDisabled"
:option-group-label="attrs.optionGroupLabel"
:option-group-children="attrs.optionGroupChildren"
Expand Down
4 changes: 2 additions & 2 deletions src/formkit/PrimeListbox.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ const styleClass = computed(() => (context?.state.validationVisible && !context?
:aria-label="attrs.ariaLabel"
:aria-labelledby="attrs.ariaLabelledby"
:options="attrs?.options"
:option-label="attrs.optionLabel ?? 'label'"
:option-value="attrs.optionValue ?? 'value'"
:option-label="attrs.optionLabel"
:option-value="attrs.optionValue"
:multiple="attrs.multiple ?? false"
:filter="attrs.filter ?? false"
:filter-icon="attrs.filterIcon"
Expand Down
4 changes: 2 additions & 2 deletions src/formkit/PrimeMultiSelect.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ const styleClass = computed(() => (context?.state.validationVisible && !context?
:aria-labelledby="attrs.ariaLabelledby"
:placeholder="attrs.placeholder"
:options="attrs.options"
:option-label="attrs.optionLabel ?? 'label'"
:option-value="attrs.optionValue ?? 'value'"
:option-label="attrs.optionLabel"
:option-value="attrs.optionValue"
:option-disabled="attrs.optionDisabled"
:option-group-label="attrs.optionGroupLabel"
:option-group-children="attrs.optionGroupChildren"
Expand Down
4 changes: 2 additions & 2 deletions src/formkit/PrimeSelectButton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ const styleClass = computed(() => (context?.state.validationVisible && !context?
:aria-label="attrs.ariaLabel"
:aria-labelledby="attrs.ariaLabelledby"
:options="attrs.options"
:option-label="attrs.optionLabel ?? 'label'"
:option-value="attrs.optionValue ?? 'value'"
:option-label="attrs.optionLabel"
:option-value="attrs.optionValue"
:option-disabled="attrs.optionDisabled"
:multiple="attrs.multiple ?? false"
:unselectable="attrs.unselectable ?? true"
Expand Down
6 changes: 6 additions & 0 deletions src/pages/demo/Dropdown.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ const schema
name: 'cookie_notice',
label: 'Cookie notice Dropdown',
value: 'hourly',
optionLabel: 'label',
optionValue: 'value',
options,
help: 'Cookie notice frequency ?',
},
Expand All @@ -26,6 +28,8 @@ const schema
value: 'hourly',
style: 'background:gray;',
class: 'customClass',
optionLabel: 'label',
optionValue: 'value',
options: [
{ label: 'Every page load', value: 'refresh' },
{ label: 'Every hour', value: 'hourly' },
Expand All @@ -40,6 +44,8 @@ const schema
showClear: true,
filter: true,
placeholder: 'Please select',
optionLabel: 'label',
optionValue: 'value',
options,
validation: 'required',
},
Expand Down
6 changes: 6 additions & 0 deletions src/pages/demo/Listbox.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ const schema
name: 'cookie_notice',
label: 'Cookie notice Dropdown',
value: 'hourly',
optionLabel: 'label',
optionValue: 'value',
options,
help: 'Cookie notice frequency ?',
},
Expand All @@ -26,6 +28,8 @@ const schema
value: 'hourly',
style: 'background:gray;',
class: 'customClass',
optionLabel: 'label',
optionValue: 'value',
options: [
{ label: 'Every page load', value: 'refresh' },
{ label: 'Every hour', value: 'hourly' },
Expand All @@ -40,6 +44,8 @@ const schema
multiple: true,
filter: true,
placeholder: 'Please select',
optionLabel: 'label',
optionValue: 'value',
options,
validation: 'required',
},
Expand Down
6 changes: 6 additions & 0 deletions src/pages/demo/MultiSelect.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ const schema
$formkit: 'primeMultiSelect',
name: 'cookie_notice',
label: 'Cookie notice MultiSelect',
optionLabel: 'label',
optionValue: 'value',
options,
help: 'Cookie notice frequency ?',
},
Expand All @@ -24,6 +26,8 @@ const schema
label: 'Styled',
style: 'background:gray;',
class: 'customClass',
optionLabel: 'label',
optionValue: 'value',
options: [
{ label: 'Every page load', value: 'refresh' },
{ label: 'Every hour', value: 'hourly' },
Expand All @@ -37,6 +41,8 @@ const schema
label: 'With Multiple Select and Filter',
filter: true,
placeholder: 'Please select',
optionLabel: 'label',
optionValue: 'value',
options,
validation: 'required',
},
Expand Down
2 changes: 2 additions & 0 deletions src/pages/demo/RadioButton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ const schema
name: 'basic',
options_class: 'mt-1 flex flex-col space-y-2',
option_class: 'flex space-x-2',
optionLabel: 'label',
optionValue: 'value',
options: [
{ label: 'Every page load', value: 'refresh' },
{ label: 'Every hour', value: 'hourly' },
Expand Down
4 changes: 4 additions & 0 deletions src/pages/demo/SelectButton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,17 @@ const schema
label: 'SelectButton',
name: 'selectButton',
options: selectOptions,
optionLabel: 'label',
optionValue: 'value',
value: 'MAYBE',
unselectable: false,
},
{
$formkit: 'primeSelectButton',
label: 'Contact options',
name: 'selectButtonMultiple',
optionLabel: 'label',
optionValue: 'value',
options: selectOptions2,
multiple: true,
},
Expand Down