Fix attempt screen scroll regression + align Practice tab metric cards - #424
Merged
Merged
Conversation
Live preview from PR #423 showed two real problems that slipped through: - The question/answer row still triggered an internal scrollbar on real content (a 5-row decimal add/subtract problem needs ~300-310px once rendered; the previous 100svh-driven flex-fill layout could squeeze that row well below that on real viewport heights). Replaced the fragile lg:h-[calc(100svh-11rem)] whole-page-fill approach with fixed, content-tested block heights instead: the question/answer row is now a flat lg:h-[380px] (verified against the actual DecimalAlignedVertical renderer's row height, divider, and padding math, with real margin to spare), so it never needs to shrink-to-fit and never scrolls. - Hero banner repeated the sheet's concept/title text that the student already saw on the instructions page one click earlier. Merged the hero and the 4-stat row into a single bigger info bar that shows the *current question's section* (not the redundant sheet title) plus answered/remaining/current/timer, and stripped QuestionCard's own header down to just the question number + save-status chip (removing the second copy of the section label that lived there too). - Also caught and fixed one more stale MCQ-era string in MathQuestionDisplay's financial-table renderer ('Select the correct calculated result from the options.' -> typed-answer copy) while auditing every display type against the new fixed pane height. - Practice tab: MetricCard was hand-rolling its own card/shine styling instead of using the shared math-student-metric-card class + the canonical diagonal sweep-shine markup used everywhere else (see Info() in assessment-readiness/page.tsx). Rewritten to match exactly so the 6 top cards are visually consistent with the rest of the student login instead of a slightly-off lookalike. Verified: syntax-checked all 4 files via the TS compiler API; measured DecimalAlignedVerticalQuestion's actual row/divider/padding CSS values by hand to confirm the new 380px pane has real margin above the ~306px this exact question type needs, instead of guessing a number again.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
sg2499
added a commit
that referenced
this pull request
Aug 4, 2026
Per feedback on the PR #424 preview: the 4 stat tiles (Answered/ Remaining/Current/Timer) and the Lesson/DPS badge were too small to read comfortably; the section-name heading was fine as-is or could come down slightly. Left the question-progress pill and overall bar structure untouched. - CompactStat/CompactTimerStat: bigger icon chip (8->10), bigger padding and value text (text-sm -> text-lg), timer pill no longer force-shrunk (reverted to TestTimer's natural px-3.5/py-2/text-sm size). - Lesson/DPS badge: px-2.5/py-1/text-[10px] -> px-3.5/py-1.5/text-xs. - Section name h1: text-lg/xl -> text-base/lg (slight downsize, per explicit ask). To keep the whole screen still fitting in one view with zero scrolling, trimmed QuestionCard's fixed content-row height from 380px to 360px -- still comfortably above the ~306px the worst-case (5-row decimal) question needs, so this doesn't reopen the scrollbar regression fixed in #424.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the internal scrollbar on the question/answer row (fixed pane height replaces the fragile 100svh calc, sized against the actual worst-case content), removes the redundant hero title (merged into one bigger info bar showing the current section instead), and aligns the Practice tab's 6 metric cards to the shared gamified card styling used elsewhere in the student login.