Fix complete Code Review results presentation

[sgardoll]

Summary

• keep the prompting sidebar visible while Results fills the entire remaining column
• preserve top-level artifact reviews when a bundleReview is present and treat informational findings as passing evidence
• require overall score, summary, and findings in future Code Review responses
• show complete bundle findings and suggestions, use verdict-appropriate empty states, and remove leaked raw review JSON
• tighten the Summary hierarchy without moving the bottom action row

Verification

• npm test (76 passed)
• npm run build
• git diff --check
• browser verified at 1800x987: 420px sidebar, 1380px Results column, correct Summary/file states, empty legacy output, and bottom-aligned actions

[greptile-apps]

Greptile Summary

The PR expands and restructures Code Review presentation behavior.

• Keeps the prompting sidebar visible beside desktop Results.
• Preserves top-level artifact reviews when bundleReview supplies the overall review.
• Treats informational findings as passing evidence and renders complete finding suggestions.
• Adds explicit review-output requirements and verdict-specific empty states.
• Clears legacy raw review output and revises the Summary layout.

Confidence Score: 3/5

The mobile Results layout and overall-review fallback handling need to be fixed before merging.

Narrow viewports place a full-height sidebar before Results, and an empty or malformed bundleReview suppresses valid overallReview data.

Files Needing Attention: index.html, app.js, src/reviewPresentation.js

Important Files Changed

Filename	Overview
app.js	Updates Results rendering, sidebar activation, finding suggestions, empty states, and legacy-output cleanup.
index.html	Revises the fullscreen Summary layout but leaves the always-visible sidebar incompatible with the existing mobile column layout.
src/reviewPresentation.js	Preserves artifact reviews alongside bundleReview, but validates the preferred overall-review container only after it has shadowed valid fallbacks.
src/pipelineContracts.js	Adds explicit required fields and score bounds to the review prompt.
src/reviewPresentation.test.js	Covers combined bundle-level and top-level artifact reviews but not malformed bundleReview fallback behavior.
src/pipelineContracts.test.js	Verifies the new structured review-output requirements.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Show Code Review results] --> B{Viewport width}
  B -->|Above 768px| C[Sidebar and Results remain side by side]
  B -->|768px or below| D[App shell stacks vertically]
  D --> E[Sidebar occupies at least 100dvh]
  E --> F[Results occupy another 100dvh below]

Loading

Comments Outside Diff (1)

1. src/reviewPresentation.js, line 265-272 (link)

   Malformed bundle review shadows fallback

   When a response contains an empty or non-object bundleReview alongside a valid overallReview, the truthy bundleReview is selected before validation and converted to an empty object. The valid overall score, summary, and findings are then ignored, producing an incomplete Results summary.

   Prompt To Fix With AI

   This is a comment left during a code review.
   Path: src/reviewPresentation.js
   Line: 265-272
   
   Comment:
   **Malformed bundle review shadows fallback**
   
   When a response contains an empty or non-object `bundleReview` alongside a valid `overallReview`, the truthy `bundleReview` is selected before validation and converted to an empty object. The valid overall score, summary, and findings are then ignored, producing an incomplete Results summary.
   
   How can I resolve this? If you propose a fix, please make it concise.

Prompt To Fix All With AI

Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 2
index.html:1078-1080
**Mobile results start below sidebar**

When Results opens at 768px or narrower, this rule keeps the sidebar visible while the mobile layout stacks it above the main content. Because the sidebar has a 100dvh minimum height and Results receives another 100dvh, users must scroll past a full-screen sidebar before reaching the review.

### Issue 2 of 2
src/reviewPresentation.js:265-272
**Malformed bundle review shadows fallback**

When a response contains an empty or non-object `bundleReview` alongside a valid `overallReview`, the truthy `bundleReview` is selected before validation and converted to an empty object. The valid overall score, summary, and findings are then ignored, producing an incomplete Results summary.

_{Reviews (1): Last reviewed commit: "fix: present complete code review result..." | Re-trigger Greptile}

[greptile-apps]

Mobile results start below sidebar

When Results opens at 768px or narrower, this rule keeps the sidebar visible while the mobile layout stacks it above the main content. Because the sidebar has a 100dvh minimum height and Results receives another 100dvh, users must scroll past a full-screen sidebar before reaching the review.

Prompt To Fix With AI

This is a comment left during a code review.
Path: index.html
Line: 1078-1080

Comment:
**Mobile results start below sidebar**

When Results opens at 768px or narrower, this rule keeps the sidebar visible while the mobile layout stacks it above the main content. Because the sidebar has a 100dvh minimum height and Results receives another 100dvh, users must scroll past a full-screen sidebar before reaching the review.

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!