fix: align review contract with BuildShip and harden deploy placement

[sgardoll]

Fixes two symptoms against the runPipeline backend: an empty review summary, code artifacts landing in the wrong FlutterFlow folder, and makes the review score + deploy guide mandatory on every generation.

Review (must ship every time):

• buildReviewPrompt: request bundleReview as {status, score, summary, manualActions, findings} so the request matches what the parser reads and what BuildShip's system prompt now requires.
• reviewPresentation: a missing written summary no longer falls back to the bundle description or a useless placeholder. It synthesizes an actionable deploy guide (verdict, per-artifact pass/warn/fail counts, the manual steps to take in the user's own FlutterFlow project) and explicitly flags when no numeric 0-100 score was returned, so a missing score is never mistaken for a pass.
• score + summary are enforced on the BuildShip prompt side (see paired PR) — there is no valid review without them.

Placement:

• normalizeArtifact: a missing artifactType no longer silently becomes a CustomWidget (misrouting classes/functions into lib/custom_code/widgets/); it defaults to a standalone code file (lib/custom_code/ root) and surfaces a warning. Honors artifact.deployPath.
• bundleDeployPlanner: honors deployPath; merges multiple CustomFunction artifacts into the single shared lib/flutter_flow/custom_functions.dart (verified as FlutterFlow's real layout) instead of erroring on a duplicate-path collision.
• flutterFlowArtifactValidation: corrected TYPE_FILE_HINTS to the real exported layout.

Pre-existing project state is preserved (not overwritten):

• Custom functions: the push uses FlutterFlow's functions_map and diffs generated function names against the real exported custom_functions.dart (functions_to_add = new names only, never delete), so functions already in the user's project stay.
• pubspec.yaml: resolveProjectPubspec reads the real remote pubspec and only merges in the generated packages; it aborts rather than overwrite if the project pubspec can't be read.

Paired with https://github.com/sgardoll/buildship/pull/62. All 159 tests pass.

[greptile-apps]

Greptile Summary

This PR aligns the generated review request and presentation with the BuildShip review contract while correcting FlutterFlow deployment paths and shared custom-function planning.

• Defaults untyped artifacts to standalone code files and preserves explicit deployment paths.
• Consolidates custom-function artifacts into FlutterFlow’s shared custom_functions.dart target.
• Synthesizes actionable review summaries when the backend omits written summary text or a numeric score.
• Updates FlutterFlow path hints and associated contract, planner, validation, and presentation tests.

Confidence Score: 4/5

The PR does not yet appear safe to merge because combining complete custom-function artifacts can still generate an invalid Dart file when a later artifact contains directives.

The shared-file merge copies each complete artifact body in sequence, so imports, library declarations, or part directives from later artifacts remain after earlier function declarations and can make the generated custom_functions.dart fail Dart analysis or compilation.

Files Needing Attention: src/bundleDeployPlanner.js, src/bundleDeployPlanner.test.js

Important Files Changed

Filename	Overview
src/artifactBundle.js	Changes the missing-type fallback to a standalone code file, preserves deployPath, and emits a placement warning.
src/bundleDeployPlanner.js	Honors explicit deployment paths and combines shared custom-function entries before downstream synchronization.
src/flutterFlowArtifactValidation.js	Updates deployment hints to match FlutterFlow’s exported project layout.
src/pipelineContracts.js	Requests the nested bundleReview fields consumed by the review parser.
src/reviewPresentation.js	Generates a verdict, artifact counts, manual steps, and missing-score notice when no written summary is returned.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Pipeline artifact bundle] --> B[Normalize artifact type and deployPath]
    B --> C[Build deployment entries]
    C --> D{CustomFunction at shared path?}
    D -- Multiple --> E[Combine into custom_functions.dart]
    D -- No --> F[Keep inferred or explicit target]
    E --> G[Validate deployment plan]
    F --> G
    G --> H[FlutterFlow synchronization]
    A --> I[Build review request]
    I --> J[Parse bundleReview]
    J --> K{Written summary present?}
    K -- Yes --> L[Present supplied summary and score]
    K -- No --> M[Synthesize verdict, counts, and manual steps]

Loading

_{Reviews (2): Last reviewed commit: "feat: require review score+summary+manua..." | Re-trigger Greptile}

[greptile-apps]

Merged Dart directives break compilation

When two custom-function artifacts contain complete Dart content and a later artifact includes an import, library, or part directive, this verbatim concatenation places that directive after the first function declaration, causing the generated custom_functions.dart to fail Dart analysis or compilation.

Prompt To Fix With AI

This is a comment left during a code review.
Path: src/bundleDeployPlanner.js
Line: 126-128

Comment:
**Merged Dart directives break compilation**

When two custom-function artifacts contain complete Dart content and a later artifact includes an `import`, `library`, or `part` directive, this verbatim concatenation places that directive after the first function declaration, causing the generated `custom_functions.dart` to fail Dart analysis or compilation.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

[sgardoll]

@greptileai