Skip to content

feat(client): set a default receive_timeout of 30s#8

Merged
sgerrand merged 1 commit into
mainfrom
feat/client-default-timeout
Apr 20, 2026
Merged

feat(client): set a default receive_timeout of 30s#8
sgerrand merged 1 commit into
mainfrom
feat/client-default-timeout

Conversation

@sgerrand

Copy link
Copy Markdown
Owner

💁 These changes:

  • Add a receive_timeout: 30_000 default to Client.new/3
  • Without this, requests could hang indefinitely under network failure or a slow API response
  • The default is overridable by passing receive_timeout: in the options to ExPlain.new/1
  • Update the ExPlain.new/1 docs to mention the default

@sgerrand sgerrand added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 20, 2026
Without a timeout the client could hang indefinitely on network issues
or a slow Plain API. 30s is overridable via extra_req_opts / ExPlain.new
options forwarded to Req.
@sgerrand
sgerrand force-pushed the feat/client-default-timeout branch from d5c296b to b92b82a Compare April 20, 2026 11:50
@coveralls

coveralls commented Apr 20, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 24664886769

Coverage remained the same at 100.0%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 368
Covered Lines: 368
Line Coverage: 100.0%
Coverage Strength: 7.14 hits per line

💛 - Coveralls

@sgerrand
sgerrand merged commit b82c641 into main Apr 20, 2026
14 checks passed
@sgerrand
sgerrand deleted the feat/client-default-timeout branch April 20, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants