Add noBotWizardsRoleId to block Wizard bot checkouts#262
Merged
Conversation
Adds a new role config that, when held, prevents a user from checking out a bot whose class is Wizard. Enforced both when requesting a bot by name (once its class is known) and when requesting the first available bot of a class, in both the Prisma-backed and sheet-backed account services.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
noBotWizardsRoleIdconfig, mirroring the existingnoBotsRoleId.noBotWizardsRoleId, in both/bot request <name>(checked once the bot's class is resolved) and/bot requestclass Wizard(checked up front against the requested class).PrismaPublicAccountsandSheetPublicAccountService) since either can be active depending onUSE_PRISMA_CACHE.Test plan
npx tsc --noEmitpassesnoBotWizardsRoleIdin the environment, grant it to a test account, and confirm/bot request <a Wizard bot>and/bot requestclass Wizardare denied while other classes remain checkout-ablenoBotsRoleIdbehavior (blocking all bots) is unchangedGenerated by Claude Code