Fix output-dir rule conflict (#11) + merge follow-ups - #13
Merged
Conversation
Hard Rule 1 said the only writable location is plans/, but Phase 4 directs use of advisor-plans/ when plans/ is taken. A literal reader hits a conflict. Move the exception into the rule so writable-location stays the single source of truth. Closes #11 Co-authored-by: morinim <morinim@users.noreply.github.com>
Follow-up to #4: a decision doc that the code has drifted from is itself a finding (decision drift), not a reason to suppress the finding.
Follow-up to #6: mirror the SKILL.md visibility gate into the closing-the-loop --issues steps so the two don't drift. Warn before publishing sensitive findings to a public tracker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three docs-only fixes to the skill instructions, each a distinct logical change:
fix:Hard Rule 1 output-dir contradiction (closes Conflicting allowed output directory #11) — Rule 1 said the only writable location isplans/, but Phase 4 directsadvisor-plans/whenplans/is taken. A literal rule-follower hits a conflict (refuse the fallback, or feel licensed to write outsideplans/— unpredictable which). The exception now lives in the rule itself, keeping writable-location the single source of truth. Diagnosis + wording from @morinim in Conflicting allowed output directory #11.docs:stale ADRs are findings (follow-up to Recon: ingest intent/design docs (ADRs, PRDs, CONTEXT.md, DESIGN.md) #4) — Recon: ingest intent/design docs (ADRs, PRDs, CONTEXT.md, DESIGN.md) #4 taught the advisor to treat an ADR-recorded tradeoff as by-design. This closes the gap: if the code has drifted from the decision doc, that's decision drift worth reporting, not a reason to suppress the finding.security:--issues visibility check (follow-up to security: harden skill against secret leakage and accidental disclosure #6) — security: harden skill against secret leakage and accidental disclosure #6 added a public-repo confirmation gate to SKILL.md; this mirrors it into theclosing-the-loop.md--issuessteps so the two files don't drift.Notes