ROFL

[alejandro-colomar]

I had a lot of fun. I really needed it today, so thanks! (=D

Closes: #736

[alejandro-colomar]

Changes: tfix :)

$ git range-diff HEAD^^..gh/loopity_loop HEAD^^..HEAD
1:  12ee3c0e = 1:  12ee3c0e This ain't no loop
2:  c19fcece ! 2:  efca07bd ROFL: Rolling on the floor looping
    @@ Metadata
     Author: Alejandro Colomar <alx@kernel.org>
     
      ## Commit message ##
    -    ROFL: Rolling on the floor looping
    +    ROTFL: Rolling on the floor looping
     
         Please tell me this was an easter egg :P
     

Edit: reverted; after an internet search, it seems ROFL is more common. wtf(1) supports both.

$ wtf is ROFL
ROFL: rolling on floor laughing
$ wtf is ROTFL
ROTFL: rolling on the floor laughing

[hallyn]

Note, though, per the description at #321, the point was that we would probably want to start supporting fallback at some point.

But this isn't where we'd loop anyway, I don't think, so dropping this is good.

[alejandro-colomar]

Changes:

• Rebase to master

$ git range-diff master..gh/loopity_loop shadow/master..loopity_loop 
1:  12ee3c0e = 1:  520e2f5e This ain't no loop
2:  ec56a000 = 2:  4523926a ROFL: Rolling on the floor looping
3:  7fa46d6d = 3:  1f75c41a Second verse, it gets worse; it gets no better than this
4:  0164b83a = 4:  89b0a83b Centralize error handling

[alejandro-colomar]

Changes:

• Found some isspace(3), isalpha(3), and isdigit(3) similar
  redundancies found in other files.

$ git range-diff master..gh/loopity_loop master..loopity_loop 
1:  520e2f5e = 1:  520e2f5e This ain't no loop
2:  4523926a = 2:  4523926a ROFL: Rolling on the floor looping
3:  1f75c41a < -:  -------- Second verse, it gets worse; it gets no better than this
-:  -------- > 3:  e175990c Second verse, it gets worse; it gets no better than this
4:  89b0a83b = 4:  8352db2a Centralize error handling

[hallyn]

You can get out of the getline() loop with p being invalid.

Easiest might be to set p to NULL both before and at the top of the while loop, and check whether it is NULL after the loop.

To elaborate: I don't just mean that p could be NULL or p[0] could be '\0'. p could be left pointing at an offset into line from a previous run through the loop.

[alejandro-colomar]

Fixed the two issues with p (uninitialized, and invalid value).

[alejandro-colomar]

Changes:

• Rebase to master

$ git range-diff master..gh/loopity_loop shadow/master..loopity_loop 
1:  520e2f5e = 1:  2783040d This ain't no loop
2:  4523926a = 2:  4fb24a33 ROFL: Rolling on the floor looping
3:  b5e49fc3 = 3:  7f583b62 Second verse, it gets worse; it gets no better than this
4:  5fecfe1c = 4:  3bdd3722 Centralize error handling
5:  87fa5f3c = 5:  0a194f1b lib/nss.c: Fix uninitialized use of p
6:  c7f90539 = 6:  69f2a283 lib/nss.c: Fix invalid use of p

[alejandro-colomar]

Changes:

• Reword subject line

$ git range-diff shadow/master..69f2a283 shadow/master..gh/loopity_loop 
1:  2783040d = 1:  2783040d This ain't no loop
2:  4fb24a33 = 2:  4fb24a33 ROFL: Rolling on the floor looping
3:  7f583b62 = 3:  7f583b62 Second verse, it gets worse; it gets no better than this
4:  3bdd3722 = 4:  3bdd3722 Centralize error handling
5:  0a194f1b ! 5:  dd6394e6 lib/nss.c: Fix uninitialized use of p
    @@ Metadata
     Author: Alejandro Colomar <alx@kernel.org>
     
      ## Commit message ##
    -    lib/nss.c: Fix uninitialized use of p
    +    lib/nss.c: Fix use of uninitialized p
     
         getline(3) might have never succeeded, in which case p is uninitialized
         when used in strtok_r(3).
6:  69f2a283 ! 6:  0016718e lib/nss.c: Fix invalid use of p
    @@ Metadata
     Author: Alejandro Colomar <alx@kernel.org>
     
      ## Commit message ##
    -    lib/nss.c: Fix invalid use of p
    +    lib/nss.c: Fix use of invalid p
     
         getline(3) might have succeeded in a previous iteration, in which case
         p points to an offset that is not valid.  Make p NULL at the end of the

[hallyn]

Not sure whether to say thanks or just bristle at the comments :)