Skip to content

src/passwd.c: Remove comment about a -s flag#930

Merged
hallyn merged 1 commit into
shadow-maint:masterfrom
alejandro-colomar:passwd_s
Jan 29, 2024
Merged

src/passwd.c: Remove comment about a -s flag#930
hallyn merged 1 commit into
shadow-maint:masterfrom
alejandro-colomar:passwd_s

Conversation

@alejandro-colomar
Copy link
Copy Markdown
Collaborator

That flag has never existed, AFAICS.

Closes: #929
Cc: @thalman

@alejandro-colomar
Copy link
Copy Markdown
Collaborator Author

v2 changes:

  • Remove a few more comments
$ git range-diff shadow/master gh/passwd_s passwd_s 
1:  2f83040e ! 1:  68f1c876 src/passwd.c: Remove comment about a -s flag
    @@ Metadata
     Author: Alejandro Colomar <alx@kernel.org>
     
      ## Commit message ##
    -    src/passwd.c: Remove comment about a -s flag
    +    src/passwd.c: Remove comment about flags that don't exist
     
    -    That flag has never existed, AFAICS.
    +    Those flag have never existed, AFAICS.
     
         Closes: <https://github.com/shadow-maint/shadow/issues/929>
         Cc: Tomas Halman <tomas@halman.net>
    @@ Commit message
     
      ## src/passwd.c ##
     @@ src/passwd.c: static void update_shadow (void)
    +  *
    +  *        -d      delete the password for the named account (*)
    +  *        -e      expire the password for the named account (*)
    +- *        -f      execute chfn command to interpret flags
    +- *        -g      execute gpasswd command to interpret flags
    +  *        -i #    set sp_inact to # days (*)
    +  *        -k      change password only if expired
       *        -l      lock the password of the named account (*)
       *        -n #    set sp_min to # days (*)
       *        -r #    change password in # repository

@alejandro-colomar
Copy link
Copy Markdown
Collaborator Author

v2b changes:

  • grfix
$ git range-diff shadow/master gh/passwd_s passwd_s 
1:  68f1c876 ! 1:  eb3b4d01 src/passwd.c: Remove comment about flags that don't exist
    @@ Metadata
     Author: Alejandro Colomar <alx@kernel.org>
     
      ## Commit message ##
    -    src/passwd.c: Remove comment about flags that don't exist
    +    src/passwd.c: Remove comments about flags that don't exist
     
    -    Those flag have never existed, AFAICS.
    +    Those flags have never existed, AFAICS.
     
         Closes: <https://github.com/shadow-maint/shadow/issues/929>
         Cc: Tomas Halman <tomas@halman.net>

Those flags have never existed, AFAICS.

Closes: <shadow-maint#929>
Cc: Tomas Halman <tomas@halman.net>
Cc: "Serge E. Hallyn" <serge@hallyn.com>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
@alejandro-colomar
Copy link
Copy Markdown
Collaborator Author

v2c changes:

$ git range-diff shadow/master gh/passwd_s passwd_s 
1:  eb3b4d01 ! 1:  91df1626 src/passwd.c: Remove comments about flags that don't exist
    @@ Commit message
     
         Closes: <https://github.com/shadow-maint/shadow/issues/929>
         Cc: Tomas Halman <tomas@halman.net>
    +    Cc: "Serge E. Hallyn" <serge@hallyn.com>
         Signed-off-by: Alejandro Colomar <alx@kernel.org>
     
      ## src/passwd.c ##

@hallyn hallyn merged commit 6fb7fe1 into shadow-maint:master Jan 29, 2024
@alejandro-colomar alejandro-colomar deleted the passwd_s branch January 29, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bogus comment about a -s flag in passwd.c

2 participants