B#74 ethercat grant#76
Merged
AndriyPt merged 2 commits intoshadow-robot:kinetic-develfrom Mar 22, 2019
Merged
Conversation
Contributor
|
@guihomework please rebase PR for clean merge since #75 was merged. |
…oses LD_LIBRARY_PATH)
guihomework
force-pushed
the
B#74_ethercat_grant
branch
from
8315580 to
5dd18ea
Compare
Contributor
Author
|
Rebased, and I also double checked that it is compatible with kinetic. It compiles and runs (not tested on a real hand, but the ethercat loop starts and finds all dependencies). |
Contributor
|
@guihomework thank you for rebase. |
… avoid issues with RUNPATH when using ethercat_grant (liburdf.so needs it but with RUNPATH it does not find it when using ethercat_grant)
guihomework
force-pushed
the
B#74_ethercat_grant
branch
from
5dd18ea to
8238dde
Compare
Contributor
Author
|
indeed. done |
AndriyPt
approved these changes
Mar 22, 2019
This was referenced Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #74 via 2 commits, both needed. A third commit is needed to compile ans is available there #75. When #75 is merged, I can rebase this PR if you like a clean merge.