-
-
Notifications
You must be signed in to change notification settings - Fork 62
Closed
Description
Hi , it seems that the cypress configuration for middleware defaults to true
https://github.com/shakacode/cypress-on-rails/blob/master/lib/cypress_on_rails/configuration.rb#L10
I've added the configuration on the initializer but the railitie runs first, so the setting is always true !. This is a serious vulnerability.
The Railtie has to initialize the configuration on after_initializer , instead initializer this way will hook the user's configuration
module CypressOnRails
class Railtie < Rails::Railtie
config.after_initialize do |app|
if CypressOnRails.configuration.use_middleware?
app.middleware.use Middleware
end
end
endgrantspeelman
Metadata
Metadata
Assignees
Labels
No labels