Skip to content

Topic recognition#482

Merged
shakes76 merged 31 commits into
shakes76:topic-recognitionfrom
JacobDS-01:topic-recognition
Nov 20, 2022
Merged

Topic recognition#482
shakes76 merged 31 commits into
shakes76:topic-recognitionfrom
JacobDS-01:topic-recognition

Conversation

@JacobDS-01

Copy link
Copy Markdown

Dear Teaching Team,

I am creating a pull request as I have implemented a VQVAE generative model on the OASIS dataset for your consideration.
Training of the VQVAE and DCGAN models went well. The VQVAE model produced very good results. The DCGAN appeared to generate good outputs (model converged) however I had trouble visualizing the generated codebook indices. I would greatly appreciate your feedback, and this can hopefully be resolved.

Kind Regards,
Jacob

JacobDS-01 and others added 30 commits October 7, 2022 11:19
…der class for OASIS dataset, configured cuda.
@SiyuLiu0329

SiyuLiu0329 commented Nov 9, 2022

Copy link
Copy Markdown
Collaborator

This is an initial inspection, no action is required at this point

  • VQ reconstruction: OK
  • VQ image generation: conventional VQVAE uses auto-regressive generation but a DCGAN is used here. Good attempt but image generation not quite working.
  • some commit messages could use more detailed descriptions

@shakes76

Copy link
Copy Markdown
Owner

Good Practice (Design/Commenting, TF/Torch Usage)

Adequate use and implementation (DCGAN used and results low quality) -2
Good spacing and comments
Header blocks

Recognition Problem

Solves problem (poor generation) -2
Driver Script present
File structure present
Shows Usage & Demo & Visualisation & Data usage
Module present
Commenting
No Data leakage
Difficulty: Hard

Commit Log

Meaningful commit messages, could be more descriptive -1
Progressive commits used

Documentation

ReadMe acceptable
Good Description and Comments
Markdown used PDF submitted

Pull Request

Successful Pull Request (Working Algorithm Delivered on Time in Correct Branch)
No Feedback required
Request Description OK, could be more informative -1
LATE -16 (restore if extension was approved)

@shakes76 shakes76 merged commit 4ddb292 into shakes76:topic-recognition Nov 20, 2022
@shakes76

Copy link
Copy Markdown
Owner

Extension was approved. +16 marks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants