Skip to content

BCKND-23: Tags improvenent#5

Merged
AlexDyakonov merged 6 commits into
mainfrom
BCKND-23/tags-improvement
Sep 2, 2024
Merged

BCKND-23: Tags improvenent#5
AlexDyakonov merged 6 commits into
mainfrom
BCKND-23/tags-improvement

Conversation

@AlexDyakonov

Copy link
Copy Markdown
Member

No description provided.

@linear

linear Bot commented Sep 2, 2024

Copy link
Copy Markdown

@vaniog

vaniog commented Sep 2, 2024

Copy link
Copy Markdown
Member

e2e упали

@vaniog

vaniog commented Sep 2, 2024

Copy link
Copy Markdown
Member

перезапусти, это норм

@AlexDyakonov AlexDyakonov requested a review from vaniog September 2, 2024 20:28
Comment thread internal/usecase/place.go Outdated
return uniquePlaces
}

func fetchTagIDsByNames(place *domain.TwoGisPlace, tags []*domain.Tag) ([]int64, error) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Сделай чтобы принимало не place, а []string
Кажется так читаемей будет

@vaniog vaniog left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Кайф

@AlexDyakonov AlexDyakonov merged commit d1472bc into main Sep 2, 2024
@AlexDyakonov AlexDyakonov deleted the BCKND-23/tags-improvement branch September 8, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants