update attestation and sync committee voting and aggregation timing i…

[shane-moore]

Changes

• update attestation deadline to 1/4 through slot
• update attestation aggregation deadline to 1/2 through slot
• update sync committee deadline to 1/4 through slot
• update sync aggregation deadline to 1/2 through slot

All per spec

[eserilev]

Hey @shane-moore, just looking through some of your PR's. great work so far

For this change, we have a pre-requisite PR here:
sigp#7944

The "slot compoenents" i.e. attestation deadline, sync committee deadlines, etc. are now all config driven. I think this PR should probably build on top of the PR I linked above. We should hopefully have that merged into unstable pretty soon.

[shane-moore]

Hey @shane-moore, just looking through some of your PR's. great work so far

For this change, we have a pre-requisite PR here: sigp#7944

The "slot compoenents" i.e. attestation deadline, sync committee deadlines, etc. are now all config driven. I think this PR should probably build on top of the PR I linked above. We should hopefully have that merged into unstable pretty soon.

hey @eserilev, really appreciate you taking a look!

Def agree that this PR will need some refactors. I figured that would be the case when I saw the v1.6.0-beta.0 release had a PR 4589 to add helper functions for slot deadlines. And it looks like the PR 7944 you made is built based on the consensus spec PR 4476, which seems to be a precursor to PR 4589

Is the plan to first get your PR merged and then later, incorporate the changes from consensus spec PR 4589? if so, I would perhaps want to refactor this PR based off the future sigp PR that adds in the PR 4589 changes?

the way it will probably work regardless is that unstable will get rebased into gloas-containers and that will get rebased into gloas-envelope-processing, if I had to guess. then, I'd rebase this PR from gloas-envelope-processing, modify accordingly, and open the PR against sigp gloas-envelope-processing

[shane-moore]

Closing — superseded upstream.

sigp#7944 ("Replace INTERVALS_PER_SLOT with explicit slot component times", commit 3ecf96438, merged 2026-02-01) replaces the hardcoded slot_duration / 3 constants in both attestation_service.rs and sync_committee_service.rs with fork-aware spec methods (get_unaggregated_attestation_due, get_aggregate_attestation_due, get_sync_message_due, get_contribution_message_due) defined in consensus/types/src/core/chain_spec.rs:884-918. The spec layer is GLOAS-aware (e.g. get_attestation_due dispatches to unaggregated_attestation_due_gloas when gloas_enabled()), tracking the same consensus-specs PR (sigp#4476) cited in this PR's body.

Upstream's approach is strictly better — timings come from spec config rather than hardcoded fractions, so future fork retunings don't require code changes.